Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): expose rule name via RuleModule interface#11719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
y-hsgw wants to merge13 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromy-hsgw:feat/add-name-to-rulemodule

Conversation

@y-hsgw
Copy link
Contributor

@y-hsgwy-hsgw commentedOct 25, 2025•
edited
Loading

PR Checklist

Overview

The previous PR#11616 was reverted after a discussion in#11662 pointing out that thename argument inwithoutDocs should be optional.
This PR reintroduces the change from#11616 while keeping name optional.

🍂

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedOct 25, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit28af1c9
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/69376dfd75dc850008d5fcc8
😎 Deploy Previewhttps://deploy-preview-11719--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 95 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@y-hsgwy-hsgw changed the titleFeat/add name to rulemodulefeat(eslint-plugin): expose rule name via RuleModule interfaceOct 25, 2025
@nx-cloud
Copy link

nx-cloudbot commentedOct 25, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit28af1c9

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded4m 50sView ↗
nx run-many -t lint✅ Succeeded3m 12sView ↗
nx run-many -t typecheck✅ Succeeded2m 8sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded10sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run generate-configs✅ Succeeded8sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
nx run types:build✅ Succeeded2sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-12-09 00:43:40 UTC

@codecov
Copy link

codecovbot commentedOct 25, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.54%. Comparing base (32b7e89) to head (28af1c9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11719   +/-   ##=======================================  Coverage   90.53%   90.54%           =======================================  Files         523      523             Lines       53096    53101    +5       Branches     8838     8838           =======================================+ Hits        48073    48082    +9+ Misses       5010     5006    -4  Partials       13       13
FlagCoverage Δ
unittest90.54% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/rule-tester/src/RuleTester.ts73.93% <100.00%> (+0.02%)⬆️
packages/utils/src/eslint-utils/RuleCreator.ts93.75% <100.00%> (+9.65%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for restarting this! Could you please add tests ensuring the regressions noted in#11608 & linked don't happen again?

y-hsgw reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelNov 3, 2025
@y-hsgw
Copy link
ContributorAuthor

I’ve added tests.91e97bc

@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelNov 3, 2025
@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelNov 18, 2025
@kirkwaiblingerkirkwaiblinger removed the awaiting responseIssues waiting for a reply from the OP or another party labelDec 6, 2025
kirkwaiblinger
kirkwaiblinger previously approved these changesDec 6, 2025
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelDec 6, 2025
@github-actionsgithub-actionsbot removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelDec 7, 2025
Comment on lines 93 to 96
return{
...ruleWithDocs,
name,
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems like overkill to make another runtime change here just to satisfy the checker.

Maybe we just use an assertion here?

Suggested change
return{
...ruleWithDocs,
name,
};
returnruleWithDocsastypeofruleWithDocs&{name:string};

y-hsgw reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed it in28af1c9.

kirkwaiblinger
kirkwaiblinger previously approved these changesDec 8, 2025
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelDec 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger left review comments

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feature request] Expose the rule name as a property

3 participants

@y-hsgw@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp