typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(typescript-estree): align constructor literal with eslint#11299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 3 commits intotypescript-eslint:mainfromntdiary:align-constructor-literal-with-eslint

Jun 16, 2025

Merged

fix(typescript-estree): align constructor literal with eslint#11299

bradzacher merged 3 commits intotypescript-eslint:mainfromntdiary:align-constructor-literal-with-eslint

Jun 16, 2025

+795 −8

Conversation

Copy link

Contributor

ntdiary commentedJun 12, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug:key of constructor inclass C { "constructor"() {} } should not be anIdentifier #11084
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

cases:

// LiteralclassA{"constructor"(){}}// IdentifierclassB{constructor(){}}

💖

align constructor literal with eslint

dd117a8

Copy link

Contributor

typescript-eslintbot commentedJun 12, 2025

Thanks for the PR,@ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJun 12, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`f6d3167`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/684fd4b6a93ae40008f99f88
😎 Deploy Preview	https://deploy-preview-11299--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedJun 12, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitf6d3167.

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 4s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 2s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	18s	View ↗
`nx run-many -t lint`	✅ Succeeded	14s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	6s	View ↗
`nx run generate-configs`	✅ Succeeded	7s	View ↗
`nx run types:build`	✅ Succeeded	1s	View ↗
`nx run integration-tests:test`	✅ Succeeded	<1s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-06-16 08:35:38 UTC

Copy link

codecovbot commentedJun 12, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is0% with18 lines in your changes missing coverage. Please review.

Project coverage is 90.84%. Comparing base(af94f16) to head(f6d3167).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/typescript-estree/src/convert.ts	0.00%	18 Missing⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11299      +/-   ##==========================================- Coverage   90.85%   90.84%   -0.02%==========================================  Files         501      501                Lines       50901    50911      +10       Branches     8383     8383              ==========================================  Hits        46248    46248- Misses       4638     4648      +10  Partials       15       15

Flag	Coverage Δ
unittest	`90.84% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/typescript-estree/src/convert.ts	`30.27% <0.00%> (-0.10%)`	⬇️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.