Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
chore(visitor-keys): bumpeslint-visitor-keys
dependency#11294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore(visitor-keys): bumpeslint-visitor-keys
dependency#11294
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@overlookmotel! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedJun 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedJun 10, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commit1380b73.
☁️Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks!
445514a
intotypescript-eslint:mainUh oh!
There was an error while loading.Please reload this page.
Out of curiosity, why are we not using |
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
ExportSpecifier
are not in source code order #11293Overview
Fix#11293 by bumping dependency of
eslint-visitor-keys
to v4.2.1.As mentioned in#11293, as far as I can see, this is the only substantive change made in v4.2.1, so I think it should be possible to bump
eslint-visitor-keys
dependency in isolation, without breaking anything else.No-one has had a chance to respond on#11293 yet, so I'm jumping the gun by submitting a PR. However, judging by#11279, I assume this will be considered a bug, and I thought a PR would help verify that this fix doesn't break anything.
If I'm out of line, please feel free to close this!