Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(visitor-keys): bumpeslint-visitor-keys dependency#11294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

overlookmotel
Copy link
Contributor

@overlookmoteloverlookmotel commentedJun 10, 2025
edited by bradzacher
Loading

PR Checklist

Overview

Fix#11293 by bumping dependency ofeslint-visitor-keys to v4.2.1.

As mentioned in#11293, as far as I can see, this is the only substantive change made in v4.2.1, so I think it should be possible to bumpeslint-visitor-keys dependency in isolation, without breaking anything else.

No-one has had a chance to respond on#11293 yet, so I'm jumping the gun by submitting a PR. However, judging by#11279, I assume this will be considered a bug, and I thought a PR would help verify that this fix doesn't break anything.

If I'm out of line, please feel free to close this!

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@overlookmotel!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 10, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit1380b73
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/684874d2d1a2700008419336
😎 Deploy Previewhttps://deploy-preview-11294--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 10, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commit1380b73.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 4sView ↗
nx run-many -t typecheck✅ Succeeded1m 54sView ↗
nx test typescript-estree --coverage=false✅ Succeeded18sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded7sView ↗
nx run-many -t lint✅ Succeeded10sView ↗
nx run types:build✅ Succeeded9sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
nx run generate-configs✅ Succeeded11sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-10 18:20:45 UTC

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks!

@bradzacherbradzacher merged commit445514a intotypescript-eslint:mainJun 10, 2025
66 of 67 checks passed
@overlookmoteloverlookmotel deleted the bump-eslint-visitor-keys branchJune 11, 2025 11:47
@fisker
Copy link
Contributor

Out of curiosity, why are we not usingworkspace:^? Not supported?

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Visitor keys forExportSpecifier are not in source code order
3 participants
@overlookmotel@fisker@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp