Jun 10, 2025 · Jun 10, 2025 · Jun 10, 2025 · Jun 16, 2025
diff --git a/packages/website/src/components/Playground.tsx b/packages/website/src/components/Playground.tsx
            onMarkersChange={setMarkers}
            onSelect={setPosition}
            selectedRange={selectedRange}
            setState={setState}
          />
        </Panel>
        <PanelResizeHandle className={styles.PanelResizeHandle} />
diff --git a/packages/website/src/components/editor/useSandboxServices.ts b/packages/website/src/components/editor/useSandboxServices.ts
 import type { createTypeScriptSandbox } from '../../vendor/sandbox';
 import type { CreateLinter } from '../linter/createLinter';
 import type { PlaygroundSystem } from '../linter/types';
 import type { RuleDetails } from '../types';
 import type {ConfigModel,RuleDetails } from '../types';
 import type { CommonEditorProps } from './types';

 import rootPackageJson from '../../../../../package.json';
    ruleDetails: RuleDetails[],
    tsVersions: readonly string[],
  ) => void;
  readonly setState: (value: Partial<ConfigModel>) => void;
  readonly ts: string;
 }

      })
      .catch((err: unknown) => {
        if (err instanceof Error) {
          if (
            err.message ===
            'Could not get all the dependencies of sandbox set up!'
          ) {
            props.setState({ ts: process.env.TS_VERSION });
          }
          setServices(err);
        } else {
          setServices(new Error(String(err)));
Original file line number	Diff line number	Diff line change
Expand Up		@@ -152,6 +152,7 @@ function Playground(): React.JSX.Element {
		onMarkersChange={setMarkers}
		onSelect={setPosition}
		selectedRange={selectedRange}
		setState={setState}
		/>
		</Panel>
		<PanelResizeHandle className={styles.PanelResizeHandle} />
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -7,7 +7,7 @@ import semverSatisfies from 'semver/functions/satisfies';
		import type { createTypeScriptSandbox } from '../../vendor/sandbox';
		import type { CreateLinter } from '../linter/createLinter';
		import type { PlaygroundSystem } from '../linter/types';
		import type { RuleDetails } from '../types';
		import type {ConfigModel,RuleDetails } from '../types';
		import type { CommonEditorProps } from './types';

		import rootPackageJson from '../../../../../package.json';
Expand All		@@ -23,6 +23,7 @@ export interface SandboxServicesProps {
		ruleDetails: RuleDetails[],
		tsVersions: readonly string[],
		) => void;
		readonly setState: (value: Partial<ConfigModel>) => void;
		readonly ts: string;
		}

Expand DownExpand Up		@@ -140,6 +141,12 @@ export const useSandboxServices = (
		})
		.catch((err: unknown) => {
		if (err instanceof Error) {
		if (
		err.message ===
		'Could not get all the dependencies of sandbox set up!'
Copy link Member JoshuaKGoldbergJun 16, 2025• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. [Refactor] A couple issues with the implementation as-is: I had to do a find-all to see where this magic string came from. -1 from me on using magic:https://softwareengineering.stackexchange.com/questions/365339/what-is-wrong-with-magic-strings I also think that continuing to use`catch` /`reject` as a form of control flow is not ideal here. Especially now that we know there's a real case to be handled with an "error" state.https://www.joshuakgoldberg.com/blog/try-catch-as-little-as-possible But, stepping back, I think this is too wide of a check.Any error rejection from`loadSandbox` will run`props.setState({ ts: process.env.TS_VERSION });` Even if it wasn't a TS version error in the first place! Requesting changes: The reset of`ts` state should only happen if: a. The existing`ts` version is an unsupported one b. The failure is specifically for the`vs/editor/editor.main` Switch the return type of`loadSandbox` to be something like a discriminated union, so the failure state is captured in the type system
		) {
		props.setState({ ts: process.env.TS_VERSION });
		}
		setServices(err);
		} else {
		setServices(new Error(String(err)));
Expand Down