Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(website): update hash value if problem occurs due to ts version error#11292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
developer-bandi wants to merge3 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromdeveloper-bandi:website/tsversion-error

Conversation

developer-bandi
Copy link
Contributor

PR Checklist

Overview

If an error occurs due to the ts version, hash's ts is modified to load the latest version.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 10, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit95ba0c0
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/684839c641507700082ee3ed
😎 Deploy Previewhttps://deploy-preview-11292--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@developer-bandideveloper-bandi changed the titlefix(website): acquired types are shown in the editor but not reflected in lintingfix(website): update hash value if problem occurs due to ts version errorJun 10, 2025
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 10, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit95ba0c0.

CommandStatusDurationResult
nx run-many -t typecheck✅ Succeeded2m 14sView ↗
nx run-many -t lint✅ Succeeded13sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded<1sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
nx run generate-configs✅ Succeeded7sView ↗
nx run types:build✅ Succeeded1sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded<1sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-10 14:02:09 UTC

@codecovCodecov
Copy link

codecovbot commentedJun 10, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base(1e0ba62) to head(95ba0c0).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11292      +/-   ##==========================================- Coverage   90.91%   90.85%   -0.06%==========================================  Files         501      501                Lines       50869    50901      +32       Branches     8382     8383       +1     ==========================================  Hits        46248    46248- Misses       4606     4638      +32  Partials       15       15
FlagCoverage Δ
unittest90.85% <ø> (-0.06%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A good start, thanks for getting it started! I left some refactor changes to make the code a bit more precise.

@@ -140,6 +141,12 @@ export const useSandboxServices = (
})
.catch((err: unknown) => {
if (err instanceof Error) {
if (
err.message ===
'Could not get all the dependencies of sandbox set up!'
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldbergJun 16, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Refactor] A couple issues with the implementation as-is:

But, stepping back, I think this is too wide of a check.Any error rejection fromloadSandbox will runprops.setState({ ts: process.env.TS_VERSION }); Even if it wasn't a TS version error in the first place!

Requesting changes:

  • The reset ofts state should only happen if:
    a. The existingts version is an unsupported one
    b. The failure is specifically for thevs/editor/editor.main
  • Switch the return type ofloadSandbox to be something like a discriminated union, so the failure state is captured in the type system

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelJun 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: playground in a weird state when using unsupported TS version
2 participants
@developer-bandi@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp