Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(eslint-plugin): switch auto-generated test cases to hand-written in no-base-to-string.test.ts#11273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
nayounsang wants to merge1 commit intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromnayounsang:hand-write-test-nbts

Conversation

nayounsang
Copy link

@nayounsangnayounsang commentedJun 5, 2025•
edited
Loading

PR Checklist

Overview

  • Change dynamic test cases using spread and map to hand-written ones
  • Specify existing recurring cases through comments

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nayounsangnayounsang marked this pull request as draftJune 5, 2025 09:08
@netlifyNetlify
Copy link

netlifybot commentedJun 5, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitd21ff60
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68415e8e5e00b5000880b828
😎 Deploy Previewhttps://deploy-preview-11273--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 5, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitd21ff60.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 1sView ↗
nx run-many -t typecheck✅ Succeeded1m 58sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded<1sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
nx run-many -t lint✅ Succeeded11sView ↗
nx run generate-configs✅ Succeeded7sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-05 09:22:56 UTC

"false + '';",
"false + 'text';",
'false + true;',
'false + false;',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

'false + true;','false + false;','true + true;','true + false;',

In my opinion, it would be neater to leave only one of these.

Copy link
Author

@nayounsangnayounsang left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Okay, I guess I can remove duplicate or unnecessary test cases now that I've changed to hand-written ones, but there are more than I thought and it's confusing me.
Let's go through this step by step with me. Excuse me, but I need to ask for your help!

@nayounsangnayounsang changed the titlechore(eslint-plugin): switch auto-generated test cases to hand-writtenchore(eslint-plugin): switch auto-generated test cases to hand-written in no-base-to-string.test.tsJun 5, 2025
@nayounsangnayounsang marked this pull request as ready for reviewJune 5, 2025 09:24
"`${__dirname === 'foobar'}`;",
'`${{}.constructor()}`;',
'`${() => {}}`;',
'`${function () {}}`;',

// operator + +=
Copy link
Author

@nayounsangnayounsangJun 5, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Many of the test cases in theoperator + section are essentially duplicates that only differ in operand order. We could consider reducing them by half.
related to this comment:#11273 (comment)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: [no-base-to-string.test.ts] Switch auto-generated test cases to hand-written
1 participant
@nayounsang
[8]ページ先頭
©2009-2025 Movatter.jp