Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): add validation to interface extends#11271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ntdiary wants to merge3 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromntdiary:add-validation-to-interface-extends

Conversation

ntdiary
Copy link

@ntdiaryntdiary commentedJun 5, 2025•
edited
Loading

PR Checklist

Overview

The validation logic comes fromTypeScript.isPropertyAccessEntityNameExpression andisEntityNameExpression are internal functions fromTypeScript, I’ve temporarily placed them above theConverter class, not sure if that’s the good place for them. :)

These are some cases that will throw errors:

// ParenthesizedExpressioninterfaceAextends(typeoffs){}// ElementAccessExpressioninterfaceBextendsC['D']{}// OptionalChaininterfaceEextendsF?.G{}// multiple extendsinterfaceHextendsIextendsJ{}// NumericLiteralinterfaceKextends2{}// nested CallExpressioninterfaceLextendsM().N{}

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 5, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit2332e96
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/684187d2fc179c0008b44c19
😎 Deploy Previewhttps://deploy-preview-11271--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 5, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit2332e96.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5mView ↗
nx run-many -t typecheck✅ Succeeded2m 1sView ↗
nx test typescript-estree --coverage=false✅ Succeeded18sView ↗
nx run-many -t lint✅ Succeeded11sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded6sView ↗
nx run generate-configs✅ Succeeded8sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-05 12:14:47 UTC

@codecovCodecov
Copy link

codecovbot commentedJun 5, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.97%. Comparing base(936f350) to head(2332e96).

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11271      +/-   ##==========================================+ Coverage   90.91%   90.97%   +0.05%==========================================  Files         501      501                Lines       50869    50898      +29       Branches     8382     8393      +11     ==========================================+ Hits        46248    46302      +54+ Misses       4606     4581      -25  Partials       15       15
FlagCoverage Δ
unittest90.97% <100.00%> (+0.05%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/typescript-estree/src/convert.ts32.11% <100.00%> (+1.45%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -360,25 +360,6 @@ export interface Bar extends baz.test {}
code: `
import test from 'test';
import baz from 'baz';
export interface Bar extends baz().test {}
Copy link
Author

@ntdiaryntdiaryJun 5, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

FYI, this case is outdated, becauseTypeScript doesn't allowCallExpression in interface extends. :)

@ntdiaryntdiary marked this pull request as ready for reviewJune 5, 2025 12:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Forbid invalidextend ininterface
1 participant
@ntdiary
[8]ページ先頭
©2009-2025 Movatter.jp