Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: rename "directive comments" to "comment directives"#11268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mrazauskas wants to merge1 commit intotypescript-eslint:main
base:main
Choose a base branch
Loading
frommrazauskas:patch-1

Conversation

mrazauskas
Copy link
Contributor

@mrazauskasmrazauskas commentedJun 4, 2025•
edited by kirkwaiblinger
Loading

PR Checklist

Overview

This PR only renames "directive comments" into "comment directives" in documentation.

The wording is rather similar, indeed. It seems to me that "comment directives" is the preferred naming in the ecosystem:

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@mrazauskas!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 4, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3d63a45
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68402af4513c9b00081730cb
😎 Deploy Previewhttps://deploy-preview-11268--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 4, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit3d63a45.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 6sView ↗
nx run-many -t typecheck✅ Succeeded2m 1sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx run-many -t lint✅ Succeeded13sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded<1sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
nx run generate-configs✅ Succeeded8sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-04 11:27:16 UTC

@mrazauskasmrazauskas changed the titleUpdate ban-ts-comment.mdxrefactor: rename "directive comments" into "comment directives"Jun 4, 2025
@mrazauskasmrazauskas changed the titlerefactor: rename "directive comments" into "comment directives"docs: rename "directive comments" into "comment directives"Jun 4, 2025
@mrazauskasmrazauskas changed the titledocs: rename "directive comments" into "comment directives"docs: rename "directive comments" to "comment directives"Jun 4, 2025
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJun 6, 2025
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems like a fine change to me 👍

Would you mind doing a search in the repo for any other instances where we use the term "directive comments" and replacing them as well? I see several code comments with this wording and we might as well switch them, too, I think

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mrazauskas@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp