Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [await-thenable] report invalid (non-promise) values passed to promise aggregator methods#11267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ronami wants to merge2 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromronami:promise-all-race-settled

Conversation

ronami
Copy link
Member

PR Checklist

Overview

This PR tackles#1804 and adjusts the rule to report on invalid (non-promise) input passed to promise aggregator methods (Promise.all,Promise.race,Promise.allSettled, andPromise.any):

declareconstx:number[];// Unexpected iterator of non-Promise (non-"Thenable") values passed to promise aggregator.Promise.all(x);

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 1, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit20ff75d
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/683cc9925440b20008258e5f
😎 Deploy Previewhttps://deploy-preview-11267--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 1, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit20ff75d.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 3sView ↗
nx run-many -t typecheck✅ Succeeded2m 8sView ↗
nx run-many -t lint✅ Succeeded11sView ↗
nx run generate-configs✅ Succeeded8sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
nx run types:build✅ Succeeded1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded<1sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-01 21:53:22 UTC

@ronamironami changed the titlefeat(await-thenable): report invalid (non-promise) values passed to promise aggregator methodsfeat(eslint-plugin): [await-thenable] report invalid (non-promise) values passed to promise aggregator methodsJun 1, 2025
@codecovCodecov
Copy link

codecovbot commentedJun 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base(e493317) to head(20ff75d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11267      +/-   ##==========================================+ Coverage   90.91%   90.92%   +0.01%==========================================  Files         501      502       +1       Lines       50869    50945      +76       Branches     8382     8399      +17     ==========================================+ Hits        46248    46324      +76  Misses       4606     4606                Partials       15       15
FlagCoverage Δ
unittest90.92% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/await-thenable.ts100.00% <100.00%> (ø)
...slint-plugin/src/util/isPromiseAggregatorMethod.ts100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[await-thenable] warn against passing non-promise values to promise aggregators (Promise.all,Promise.allSettled,Promise.race)
1 participant
@ronami
[8]ページ先頭
©2009-2025 Movatter.jp