Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
chore: exclude docs/ directory from eslint-plugin package#11251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
chore: exclude docs/ directory from eslint-plugin package#11251
Conversation
Thanks for the PR,@roottool! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedMay 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedMay 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commitdb9e2c5.
☁️Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me! Nice eagle eyes on thedocs/rules/README.md
inclusion.
Looks like the yarn equivalent of this also includes I'm happy for us to omit explicit README and LICENSE from the |
Thank you for reviewing!
I decided not to omit them. I thought it was odd that |
PR Checklist
Overview
This PR excludes
docs/
directory from the published@typescript-eslint/eslint-plugin
package.I converted from
README.md
to./README.md
infiles
ofpackage.json
. This is becausedocs/rules/README.md is included in the eslint-plugin package afterdocs/
directory is excluded. I checked it withyarn pack --dry-run
.As an aside, I think that
README.md
infiles
can be deleted.README
is always included in thisfiles
config.