Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: remove postinstall steps from CI to speed up prepare-install action#11219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 6 commits intotypescript-eslint:mainfromkirkwaiblinger:ci-speedup
May 29, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions.github/actions/prepare-install/action.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -76,3 +76,4 @@ runs:
YARN_INSTALL_STATE_PATH: .yarn/ci-cache/install-state.gz # Very small speedup when lock does not change
# Other environment variables
HUSKY: '0' # By default do not run HUSKY install
SKIP_POSTINSTALL: 'true'
2 changes: 1 addition & 1 deletion.github/workflows/ci.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,7 +78,7 @@ jobs:
uses: ./.github/actions/prepare-install
with:
node-version: ${{ env.PRIMARY_NODE_VERSION }}
- run: yarn generate-configs
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

directly runningyarn generate-configs seems to execute the yarn script directly, ignoring thedependsOn. So, I thinkyarn nx run generate-configs executes the nx task instead, which includes the necessarydependsOn.

- run: yarnnx rungenerate-configs
- run: git status --porcelain
- if: failure()
run: echo "Outdated result detected from yarn generate-configs. Please check in any file changes."
Expand Down
3 changes: 2 additions & 1 deletionpackages/types/project.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,8 @@
"dependsOn": ["copy-ast-spec"]
},
"lint": {
"executor": "@nx/eslint:lint"
"executor": "@nx/eslint:lint",
"dependsOn": ["typescript-eslint:build", "eslint-plugin-internal:build"]
}
}
}
Loading

[8]ページ先頭

©2009-2025 Movatter.jp