Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
chore: migrateeslint-plugin-import
toeslint-plugin-import-x
#11217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Thanks for the PR,@JounQin! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedMay 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
nx-cloudbot commentedMay 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commite1bf907.
☁️Nx Cloud last updated this comment at |
PR Checklist
eslint-plugin-import
toeslint-plugin-import-x
#11212Overview
Before:
For a single ESLint plugin migration, I believe from 1m13s to 1m8s is already good enough, and it founds a false positive that
@docusaurus/plugin-content-blog
should be listed independencies
forwebsite
, becauseeslint-plugin-import-x
is a TypeScript rewrite started atun-ts/eslint-plugin-import-x#42 and we fixed several hidden bugs thanks to TypeScript!(I don't know why
nx
complains aboutreact-helmet-async
version incompatible with@docusaurus/core
's, see alsohttps://app.unpkg.com/@docusaurus/core@3.7.0/files/package.json#L63, so I'm locking it same way to makenx
happy.)cc@JoshuaKGoldberg