Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bug: Visitor keys for 5 types are not in source order #11276

Open
Labels
accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workingpackage: visitor-keysIssues related to @typescript-eslint/visitor-keys
@overlookmotel

Description

@overlookmotel

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I havesearched for related issues and found none that matched my issue.
  • I haveread the FAQ and my problem is not listed.

Relevant Package

visitor-keys

Playground Link

https://typescript-eslint.io/play/#ts=5.8.2&showAST=es&fileType=.tsx&code=PQKgUABCECoMoEkC2AHA9gJwC4wJ4oFNJoBpA3AZwC4Ja6BtAcgEMMBzAVyQIDstGANBEYBHDswA2ASwBmUghkHCs%2BAgEF2XXlgpLGaFFiloeugLrEIcABZoOEgCYQARgRpNWnbnz0GjJ3SFRcWk5BT0VQg0vbXNiYDBIggg1CABeCClUTCwACkYZNDQlAG8IZgoKBSwaMsYMAgo0CQ5-HgBaJDQHAkYaRiz0bEYIAF8xgEoAOjFJWXkMAB4YAD4AbjBgYDpaTy0%2BCAA9Y%2BPN7Z2Luj9jUyOT%2B4fHp%2BeXs8v3j8%2Bv74vZ0IW7k83j8QaCwZcktF9jpAWBNuAoLBEDwegAPAgONQAYyxjQoeEIljIlBoFyYUhRBFRBN6QTQzgAVgQsThVIwLIibHZHC43BAmPSmSyaXoKWiRRyQAkkhAAELpCAABQUTR49AARMw2AR1RAAD4QdU8ZjcdVmDZbd6PCCC5mswmWn4vJ6ZSnU1Rw0CWeAAWQIWFsDjgUjYxqwHAaRPI1EuTCSitYJv9Kr0AGtyHoUImkIFhA1wxgeBLLFz7E5XO5GOncBFVAmMEmsCmglmGzm9PmI0W2ZKEhSmxgZMxcRAAGJFCBlZysZYrXLMGg8LiuDATGgULAYClsNZjYEfauwx3x7PJjAUI-nH6tk0X16O8E7TuFmmAk6ehHQeCKjAGaq4YNQ2YAsiERYkYzJRhIR4Hg0CwYCbjTDNJSsWwy15Stq1rKIYLghCTHZeIwH7BQhxHWVWEnCAxFRRdlwUPcH3eQ93yY6DYPgto31OeFvTgGkfwxKQsWA0DSGjUkdjjVQ1FwzjEJbU8BwAOSTQjOTQnkK35Rgb24FS1KCdi8LadSpTAGQOB4FkbkyCg4E3bdciQZhcG0qzU1ggB3Hg1wgFy3OSKQLw3LceDYKjnx4CAkjQGR-Nc1x0jSDJGFC7dGF3UZ93BPSz1U7huJyx8IRkuT8Oix4wCAA&eslintrc=N4KABGBEBOCuA2BTAzpAXGYBfEWg&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

/* * TSImportType * Keys:      ['argument', 'qualifier', 'typeArguments', 'options'] * Should be: ['argument', 'options', 'qualifier', 'typeArguments'] */typeA=import('foo',{assert:{'resolution-mode':'import'}}).qualifier<T>;//     argument ^^^^^//             options ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^//                                                        qualifier ^^^^^^^^^//                                                             typeArguments ^^^/* * TSIndexedAccessType * Keys:      ['indexType', 'objectType'] * Should be: ['objectType', 'indexType'] */typeB=Person["age"|"name"];//       ^^^^^^ objectType//             ^^^^^^^^^^^^^^^^ indexType/* * TSMethodSignature * Keys:      ['typeParameters', 'key', 'params', 'returnType'] * Should be: ['key', 'typeParameters', 'params', 'returnType'] */interfaceFoo{bar<T>(a:number):string;}//          key ^^^//  typeParameters ^^^//              params ^^^^^^^^^//                      returnType ^^^^^^/* * TSPropertySignature * Keys:      ['typeAnnotation', 'key'] * Should be: ['key', 'typeAnnotation'] */interfaceBar{qux:number}//          key ^^^//    typeAnnotation ^^^^^^/* * TSTypePredicate * Keys:      ['typeAnnotation', 'parameterName'] * Should be: ['parameterName', 'typeAnnotation'] */functionisString(maybe:unknown):maybe isstring{returntypeofmaybe==='string';}//                   parameterName ^^^^^//                           typeAnnotation ^^^^^^

ESLint Config

tsconfig

Expected Result

A comment invisitor-keys package states that keys "should be sorted in the order that they appear in the source code".

/*
********************************** IMPORTANT NOTE ********************************
* *
* The key arrays should be sorted in the order in which you would want to visit *
* the child keys. *
* *
* DO NOT SORT THEM ALPHABETICALLY! *
* *
* They should be sorted in the order that they appear in the source code. *
* For example: *
* *
* class Foo extends Bar { prop: 1 } *
* ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ClassDeclaration *
* ^^^ id ^^^ superClass *
* ^^^^^^^^^^^ body *
* *
* It would be incorrect to provide the visitor keys ['body', 'id', 'superClass'] *
* because the body comes AFTER everything else in the source code. *
* Instead the correct ordering would be ['id', 'superClass', 'body']. *
* *
**********************************************************************************
*/

This is not the case for 5 types:

  • TSImportType
  • TSIndexedAccessType
  • TSMethodSignature
  • TSPropertySignature
  • TSTypePredicate

Please see above for examples.

Actual Result

Properties are visited not in source code order.

Additional Info

No response

Versions

packageversion
@typescript-eslint/visitor-keys8.33.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workingpackage: visitor-keysIssues related to @typescript-eslint/visitor-keys

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp