Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.5k
fix: order by nulls (first | last) for sqlserver issue #10860#10861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
fix: order by nulls (first | last) for sqlserver issue #10860#10861
Conversation
gioboa left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@awaismehmood88 for you help
is it still a valid PR ?
awaismehmood88 commentedJan 22, 2025
Yes, it is valid |
gioboa left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you add a test for this specific fix please?
This will help a lot our review
gioboa left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you solve the conflicts please?
PR Code Suggestions ✨
| ||||||||||||
awaismehmood88 commentedDec 17, 2025
Sorry for the late reply, I have resolved the conflicts; please merge now. |
commit: |
Uh oh!
There was an error while loading.Please reload this page.
Description of change
Fixes#10860
This change fix nulls sort for sqlserver
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #10860