Movatterモバイル変換

Skip to content

twisted/towncrierPublic

NotificationsYou must be signed in to change notification settings
Fork129
Star871

Improve the behavior of "towncrier create"#725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft

scoopex wants to merge1 commit intotwisted:trunk

base:trunk

Choose a base branch

fromscoopex:improve_issue_format_check

Draft

Improve the behavior of "towncrier create"#725

scoopex wants to merge1 commit intotwisted:trunkfromscoopex:improve_issue_format_check

Conversation

@scoopex

Copy link

scoopex commentedSep 24, 2025•
edited
Loading

Description

Fixes#724

Checklist

Make sure changes are covered by existing or new tests.
For at least one Python version, make sure test pass on your local environment.
Create a file insrc/towncrier/newsfragments/. Briefly describe your
changes, with information useful to end users. Your change will be included in the public release notes.
Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
Ensuredocs/tutorial.rst is still up-to-date.
If you add newCLI arguments (or change the meaning of existing ones), make suredocs/cli.rst reflects those changes.
If you add newconfiguration options (or change the meaning of existing ones), make suredocs/configuration.rst reflects those changes.

@scoopex

scoopex requested a review froma team as acode owner

September 24, 2025 21:35

@scoopex

scoopex changed the title~~Improve issue format check~~WIP: Improve issue format check

@scoopex

scoopex force-pushed theimprove_issue_format_check branch from660f339 to91841f0Compare

September 24, 2025 21:37

adiroiban

adiroiban requested changes

View reviewed changes

Copy link

Member

adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR.
Is this ready for review and merge?

I see the WIP in the title... if the PR is not ready for review, you can mark it as "Draft"

To have the PR merged it will need updated tests and documentation.

Also, it needs a newsfragment for the future release notes.
We are dogfooding here... towncrier uses towncrier :)

Let me know if you need help with the docs and tests.

Thanks gain for your contribution.

@scoopex

scoopex marked this pull request as draft

September 25, 2025 11:44

@scoopex

Copy link

Author

scoopex commentedSep 25, 2025

Sorry, i was aware of that option but had not found that option yesterday :-)

@scoopex

scoopex changed the title~~WIP: Improve issue format check~~Improve issue format check

@scoopex

scoopex force-pushed theimprove_issue_format_check branch from94ad1f6 to7f0198aCompare

September 25, 2025 18:05

@adiroiban

Copy link

Member

adiroiban commentedSep 25, 2025

No problem.
When creating a new PR, the option is in the "Create PR" button

@scoopex

scoopex force-pushed theimprove_issue_format_check branch 4 times, most recently from09eae2a to89c5b46Compare

September 26, 2025 10:13

@scoopex

scoopex changed the title~~Improve issue format check~~Improve the behavio of "towncrier create"

@scoopex

scoopex mentioned this pull request

Feature request: More convenient creation of fragments#724

Open

@scoopex

scoopex changed the title~~Improve the behavio of "towncrier create"~~Improve the behavior of "towncrier create"

@pre-commit-ci

Implementtwisted#724

4ebde34

@scoopex

scoopex force-pushed theimprove_issue_format_check branch from4d9d8c6 to4ebde34Compare

October 15, 2025 07:20

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

2 participants

@scoopex

@adiroiban

[8]ページ先頭

©2009-2025 Movatter.jp