- Notifications
You must be signed in to change notification settings - Fork549
feat: Add Cloudflare Workers support to Twilio SDK#1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge5 commits intomainChoose a base branch fromcopilot/fix-1096
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: tiwarishubham635 <59199353+tiwarishubham635@users.noreply.github.com>
Co-authored-by: tiwarishubham635 <59199353+tiwarishubham635@users.noreply.github.com>
…upportCo-authored-by: tiwarishubham635 <59199353+tiwarishubham635@users.noreply.github.com>
Copilot finished work on behalf oftiwarishubham635September 12, 2025 12:53
abegehr commentedSep 13, 2025
🥰 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR implements cross-platform compatibility for the Twilio Node.js SDK, enabling it to run in Cloudflare Workers and other JavaScript runtimes without Node.js-specific dependencies.
Problem
The Twilio SDK previously failed in Cloudflare Workers with the error:
This occurred because the SDK relied on Node.js-specific modules like
fs
,https
,Buffer
, andprocess
that aren't available in the Workers runtime.Solution
Implemented automatic runtime detection and conditional module loading:
src/base/runtime.ts
) - Detects Node.js vs Cloudflare Workers vs Browser environmentssrc/base/FetchRequestClient.ts
) - Uses fetch API instead of axios for non-Node.js environmentsUsage in Cloudflare Workers
Benefits
Files Changed
src/base/runtime.ts
- New runtime detection utilitiessrc/base/FetchRequestClient.ts
- New fetch-based HTTP clientsrc/base/RequestClient.ts
- Updated to auto-select HTTP implementationsrc/base/BaseTwilio.ts
- Cross-platform environment variable handlingsrc/auth_strategy/BasicAuthStrategy.ts
- Cross-platform base64 encodingsrc/auth_strategy/TokenAuthStrategy.ts
- Conditional JWT parsingThe implementation maintains full backward compatibility while extending support to new JavaScript runtimes.
Fixes#1096.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.