- Notifications
You must be signed in to change notification settings - Fork549
Replace axios with fetch to reduce bundle size and allow custom HTTP clients#1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge4 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: tiwarishubham635 <59199353+tiwarishubham635@users.noreply.github.com>
Co-authored-by: tiwarishubham635 <59199353+tiwarishubham635@users.noreply.github.com>
Co-authored-by: tiwarishubham635 <59199353+tiwarishubham635@users.noreply.github.com>
Copilot finished work on behalf oftiwarishubham635August 20, 2025 18:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR replaces the axios HTTP client with fetch in the Twilio Node.js Helper Library to significantly reduce bundle size and allow users to bring their own fetch implementation, directly addressing the bundle size concerns raised in issue#728.
Changes Made
Core Implementation:
RequestClient.tswhile maintaining the exact same public APIpackage.json(saves ~100KB+ in bundle size)fetchoption toRequestClientOptionsto allow custom fetch implementationsBackward Compatibility:
Benefits
Bundle Size Reduction:
Users can now significantly reduce bundle size by:
Flexibility:
Testing
Added comprehensive test suite (
RequestClient.fetch.spec.js) with 18 tests covering:All tests pass and verify that the fetch implementation maintains feature parity with the original axios implementation.
Documentation
advanced-examples/custom-http-client.mdto reflect fetch usageexamples/custom-fetch.mdwith usage examplesThis change enables users to dramatically reduce their bundle size while maintaining all existing functionality, directly addressing the core request in issue#728 to "let users bring in their own fetch implementation."
Fixes#898.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.edge.region.twilio.comnode /home/REDACTED/work/twilio-node/twilio-node/node_modules/.bin/jest spec --coverage --detectOpenHandles --testPathIgnorePatterns=spec/cluster --testPathPattern=RequestClient.fetch.spec.js(dns block)api.edge.region2.twilio.comnode /home/REDACTED/work/twilio-node/twilio-node/node_modules/.bin/jest spec --coverage --detectOpenHandles --testPathIgnorePatterns=spec/cluster --testPathPattern=RequestClient.fetch.spec.js(dns block)api.edge.us1.twilio.comnode /home/REDACTED/work/twilio-node/twilio-node/node_modules/.bin/jest spec --coverage --detectOpenHandles --testPathIgnorePatterns=spec/cluster --testPathPattern=RequestClient.fetch.spec.js(dns block)api.edge2.region.twilio.comnode /home/REDACTED/work/twilio-node/twilio-node/node_modules/.bin/jest spec --coverage --detectOpenHandles --testPathIgnorePatterns=spec/cluster --testPathPattern=RequestClient.fetch.spec.js(dns block)api.region.twilio.comnode /home/REDACTED/work/twilio-node/twilio-node/node_modules/.bin/jest spec --coverage --detectOpenHandles --testPathIgnorePatterns=spec/cluster --testPathPattern=RequestClient.fetch.spec.js(dns block)api.region2.domain.comnode /home/REDACTED/work/twilio-node/twilio-node/node_modules/.bin/jest spec --coverage --detectOpenHandles --testPathIgnorePatterns=spec/cluster --testPathPattern=RequestClient.fetch.spec.js(dns block)api.region2.twilio.comnode /home/REDACTED/work/twilio-node/twilio-node/node_modules/.bin/jest spec --coverage --detectOpenHandles --testPathIgnorePatterns=spec/cluster --testPathPattern=RequestClient.fetch.spec.js(dns block)api.twilio.comnode /home/REDACTED/work/twilio-node/twilio-node/node_modules/.bin/jest spec --coverage --detectOpenHandles --testPathIgnorePatterns=spec/cluster --testPathPattern=RequestClient.fetch.spec.js(dns block)iam.twilio.comnode /home/REDACTED/work/twilio-node/twilio-node/node_modules/.bin/jest spec --coverage --detectOpenHandles --testPathIgnorePatterns=spec/cluster --testPathPattern=RequestClient.fetch.spec.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.