Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Added Cancellation Token#772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
joewashear007 wants to merge8 commits intotwilio:main
base:main
Choose a base branch
Loading
fromjoewashear007:main

Conversation

joewashear007
Copy link

@joewashear007joewashear007 commentedJan 13, 2025•
edited
Loading

Fixes

Fixes#514
This PR added theCancellationToken to all the async endpoints and all of the pass throughs

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read theContribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file asupport ticket, or create a GitHub Issue in this repository.

@joewashear007joewashear007 changed the titleAdded Cancellation Tokenfeat: Added Cancellation TokenJan 13, 2025
@joewashear007joewashear007 marked this pull request as draftJanuary 13, 2025 15:20
@joewashear007joewashear007 marked this pull request as ready for reviewJanuary 15, 2025 18:56
@joewashear007
Copy link
Author

I think this PR is ready, though I think it need to be reworked. it touches many of the auto generated files. But I don't think I can edit the auto generator to add theCancellationToken to the Async methods

@sbansla
Copy link
Contributor

sbansla commentedJan 16, 2025•
edited
Loading

We are planning to change Orgs API RestClient.
We will review this change at that time.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FeatureRequest] Add CancellationToken pass-through to async request methods
2 participants
@joewashear007@sbansla
[8]ページ先頭
©2009-2025 Movatter.jp