- Notifications
You must be signed in to change notification settings - Fork3.4k
Add seamless OpenTelemetry Java agent integration#27639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors:Scott Strickland.
|
Enable automatic integration with OpenTelemetry Java agent while maintainingfull backwards compatibility with standalone tracing configuration.Fixestrinodb#27638Changes-------- Add ConditionalTracingModule that auto-detects GlobalOpenTelemetry- Add GlobalOpenTelemetryModule to bind global instance when detected- Update Server.java to use ConditionalTracingModule- Add comprehensive tests for auto-detection and override behavior- Update OpenTelemetry documentation with Java agent integration guideBehavior--------When Java agent is present:- Auto-detects GlobalOpenTelemetry and uses it (logged as "Using GlobalOpenTelemetry")- All spans share resource attributes from agent- Configuration done once via agent (OTEL_* env vars)- Single exporter, single SDK instanceWhen Java agent is NOT present:- Falls back to TracingModule (logged as "Using dedicated TracingModule")- Existing tracing.* configuration works unchanged- 100% backwards compatibleOverride--------System property or environment variable to force specific behavior: # Force use of global -Dtracing.use-global=true export TRACING_USE_GLOBAL=true # Force use of dedicated TracingModule -Dtracing.use-global=falseTesting-------Unit tests verify:- Auto-detection when GlobalOpenTelemetry is initialized- Fallback when not initialized- System property override- Backwards compatibilityDocumentation-------------- docs/src/main/sphinx/admin/opentelemetry.md: Added Java agent integration section- docs/src/main/sphinx/develop/opentelemetry-java-agent.md: Developer guide
2703ab1 tob80b238CompareThank you for your pull request and welcome to the Trino community. We require contributors to sign ourContributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA tocla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, seehttps://github.com/trinodb/cla |
1 similar comment
Thank you for your pull request and welcome to the Trino community. We require contributors to sign ourContributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA tocla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, seehttps://github.com/trinodb/cla |
a8b17c7 tod4bfcbbCompareThank you for your pull request and welcome to the Trino community. We require contributors to sign ourContributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA tocla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, seehttps://github.com/trinodb/cla |
Uh oh!
There was an error while loading.Please reload this page.
Enable automatic integration with OpenTelemetry Java agent while maintaining full backwards compatibility with standalone tracing configuration.
Fixes#27638
Changes
Behavior
When Java agent is present:
When Java agent is NOT present:
Override
System property or environment variable to force specific behavior:
Force use of global
-Dtracing.use-global=true
export TRACING_USE_GLOBAL=true
Force use of dedicated TracingModule
-Dtracing.use-global=false
Testing
Unit tests verify:
Documentation
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
() Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: