Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support rewriting headers and query parameters#201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Priyansh121096 wants to merge1 commit intotrinodb:main
base:main
Choose a base branch
Loading
fromPriyansh121096:feat-rewrite-headers-and-query-params

Conversation

@Priyansh121096
Copy link

No description provided.

@vagaerg
Copy link
Member

#205 made an interesting observation, that the rewriter cannot rewrite query parameters. This PR addresses that

requireNonNull(finalRequestKey,"finalRequestKey is null");
requireNonNull(finalRequestHeaders,"finalRequestHeaders is null");
requireNonNull(finalQueryParameters,"finalQueryParameters is null");
finalQueryParameters =finalQueryParameters.map(ImmutableMultiMap::copyOf);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nit - we don't need therequireNonNull if we are invoking a method on the object already

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vagaergvagaergvagaerg left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Priyansh121096@vagaerg

[8]ページ先頭

©2009-2025 Movatter.jp