Commit2ab4bb4

committed

Log emulated access key instead of secret key

Unsure if this was instead for the initial development phases but weshouldn't be logging this now

1 parent09a9de1 commit2ab4bb4Copy full SHA for 2ab4bb4

File tree

-2

lines changed

trino-aws-proxy-glue/src/main/java/io/trino/aws/proxy/glue/rest
- TrinoGlueResource.java
trino-aws-proxy/src/main/java/io/trino/aws/proxy/server/rest
- TrinoS3Resource.java

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public TrinoGlueResource(ObjectMapper objectMapper, GlueRequestHandler requestHa`
`59`	`59`	`@Produces(MediaType.APPLICATION_JSON)`
`60`	`60`	`publicResponsegluePost(@ContextRequestrequest,@ContextSigningMetadatasigningMetadata,@ContextRequestLoggingSessionrequestLoggingSession)`
`61`	`61`	`{`
`62`		`-requestLoggingSession.logProperty("request.glue.emulated.key",signingMetadata.credential().secretKey());`
	`62`	`+requestLoggingSession.logProperty("request.glue.emulated.access-key",signingMetadata.credential().accessKey());`
`63`	`63`
`64`	`64`	`Stringtarget =request.requestHeaders().unmodifiedHeaders().getFirst("x-amz-target")`
`65`	`65`	`.orElseThrow(() ->InvalidInputException.builder().statusCode(BAD_REQUEST.getStatusCode()).build());`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ private void handler(Request request, Optional<Identity> identity, SigningMetada`
`135`	`135`
`136`	`136`	`requestLoggingSession.logProperty("request.parsed.bucket",parsedS3Request.bucketName());`
`137`	`137`	`requestLoggingSession.logProperty("request.parsed.key",parsedS3Request.keyInBucket());`
`138`		`-requestLoggingSession.logProperty("request.emulated.key",signingMetadata.credential().secretKey());`
	`138`	`+requestLoggingSession.logProperty("request.emulated.access-key",signingMetadata.credential().accessKey());`
`139`	`139`
`140`	`140`	`proxyClient.proxyRequest(identity,signingMetadata,parsedS3Request,asyncResponse,requestLoggingSession);`
`141`	`141`	`}`

Comments

(0)