- Notifications
You must be signed in to change notification settings - Fork2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Arrow snapping behavior redux#3090
base:main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more aboutVercel for Git ↗︎
|
A key change here is making the "velocity at time of first binding" more decisive in whether to start in an imprecise or precise state. It's difficult to measure the "towards the centerness" of the arrow, but speed feels intentional (even on mobile). I also feel less in control of "time spent in the same binding". If we want to capture a "pause" intent, then we should start a timer whenever the velocity hits zeroish; and then I think we can reduce the amount of time it takes to trigger a pause. Some of the "easy" actions are:
The "harder" actions are:
By combining the harder intents with the easier actions, ie the velocity (or center-pointedness) at the time of entry, we can preserve the mode after that fact, and give a quick way of fixing the problem if in the wrong mode by leaving and re-entering, or by using a slightly less convenient mode (pausing, dragging to the center) |
Bringing this out of experiment hell, now that a few other things have landed. (And want to be sure to get it considered before we redo arrow bindings). |
This PR makes a few small changes to arrow binding / center snapping. It incorporates some of the logic from#2924
It:
Change Type
minor
— New feature, though really this shouldn't break anything that isn't relying on quirks in our shapes / statesTest Plan
Release Notes