- Notifications
You must be signed in to change notification settings - Fork231
fmt: introduce golangci-lint and go vet use CI with action and using build tag#804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
gen2thomas wants to merge1 commit intotinygo-org:devChoose a base branch fromgen2thomas:feature/linter_add_build_tags
base:dev
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8ea00db tobfc0179Compare This was referencedOct 22, 2025
703ad49 to43a4b70Compare43a4b70 to1e2eabeCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
see#802 for a general description and the version without Github action
see#803 for version with multiple runners
This PR is an alternative way to earn all features of the golangci-lintGitHub Action.
This is achieved by adding a build tag to every file that cannot be linted due to a failed compilation. This is caused by dependencies to the "machine" package of tiny-go or other such dependencies (e.g. device/arm).
Although the condition is to add a build tag in many files, it has many advantages over the other versions: