- Notifications
You must be signed in to change notification settings - Fork231
drivers.Pin with function pointers example#774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:drivers-pin-interface
Are you sure you want to change the base?
drivers.Pin with function pointers example#774
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| typePinOutinterface { | ||
| High()// deprecated: use Set(true) | ||
| Low()// deprecated: use Set(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd prefer we do not have these in the interface and sweep and eradicate call to them everywhere in drivers.
| ResetPin drivers.PinOut | ||
| DataPin drivers.PinOut | ||
| ChipSelectPin drivers.PinOut | ||
| BusyPin drivers.PinIn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Showcase use ofPinOut andPinIn interfaces.
This is pulled from a PR we agreed to not continue with at the moment. The design of#753 leaves us open for this design in the future if we so desire to go on with it. |
Uh oh!
There was an error while loading.Please reload this page.
This showcases how we can split
drivers.Pinto smallerdrivers.PinInanddrivers.PinOutinterfaces AND use function pointer to.Set(bool)function in performance critical places, likesoftspiimplementation.This still breaks users though, as it is based on a PR#749 that mandates pins to be configured outside the drivers.