- Notifications
You must be signed in to change notification settings - Fork231
Added alarm features for DS3231#758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@conejoninja PTAL 😸 |
it's on my backlog, i'll review it eventually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hello, thanks for your contribution, since you already did the work for Alarm1, does it make sense to add Alarm2 too?
Also, since we are at it, I would add a new example under /examples/ds3231 for the alarms, let's keep the one already as "basic" and another for the alarms. It would be great to show how to set an interrupt on TinyGo.
| return | ||
| } | ||
| func (d*Device)GetSqwPinMode()SqwPinMode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Exported functions need documentation
| returnSqwPinMode(data[0]) | ||
| } | ||
| func (d*Device)SetSqwPinMode(modeSqwPinMode)error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This too, exported functions need documentation
| // ALarm1 Modes | ||
| typeAlarm1Modeuint8 | ||
| const ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't be add Alarm2 too?
Hi sure can do that stuff, if it's fine around 2-3 weeks as timeline. And of course alarm2, examples, docs will be added. Just wanted to make sure, that the PR will be accepted before doing the whole work :) |
Sure, we welcome every contribution, sometimes we are a bit slower reviewing changes, but we eventually get them done. |
gKits commentedJul 23, 2025
Hi@mfulz are you still actively working on this? I can assist if needed. |
I've implemented missing features for DS3231 RTC similar likeRTClib
These can be used to set Alarm1 (alarm2 is missing), read alarm1, activate alarm1, use sqw for interrupts, etc.