Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix multiarch + Add bash_unit for testing#325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mistraloz merged 20 commits intov4fromhotfix/multiarch
Sep 21, 2022
Merged

Conversation

@mistraloz
Copy link
Collaborator

@mistralozmistraloz commentedAug 30, 2022
edited
Loading

Summary

Fix multi arch troubles and lot of related things (becareful : it's a risky PR, especialy,tini is removed and it was directly related to the entrypoint).

This PR fixes/implements :

Checklist

  • I followed the guidelines inCONTRIBUTING guide
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

TODO

Theses changes are not included in this PR (already so big) but FYI :

  • more work is required to speed up build and test (especialy for ARM)
  • some changes should be required for optimise building stages in ci (test one version before all other to avoid spaming, synchronize cache between step... or any other idea to allow more accurate testing)
  • Some php extensions are removed into arm because the build time is too long for them : swoole, rdkafka, ev and snmp.
  • Tini is disabled (as hot fix) because it's does work properly in arm build. It's may a good idea to double check if there is a breaking change (PRRun Apache2 in background #215 may help to find a smart fix).
  • There is too much extensions onto fat images, and too much variants. We should find a way to avoid that to allow a more new features and an easier maintenance.

defser reacted with rocket emoji
@mistralozmistralozforce-pushed thehotfix/multiarch branch 4 times, most recently from7eccae7 to40b1395CompareAugust 30, 2022 14:21
@mistralozmistralozforce-pushed thehotfix/multiarch branch 15 times, most recently fromda453ba toa6c958eCompareSeptember 1, 2022 17:42
@mistralozmistraloz changed the titleHotfix push with patched versionFix multiarch + Add bash_unit for testingSep 1, 2022
@mistralozmistralozforce-pushed thehotfix/multiarch branch 9 times, most recently froma7eaaaa to4b05d20CompareSeptember 5, 2022 14:04
@mistralozmistralozforce-pushed thehotfix/multiarch branch 4 times, most recently frombc8e0f7 to2f9047bCompareSeptember 19, 2022 13:14
* Lint symlink for extensions directories
…i` instead of `/var/lib/php/modules/${PHP_VERSION}/registry/*`
* Allow to change related repository with ARG* Allow to suffix tag with ARG* Allow to change FROM_IMAGE with ARG (to allow some optimisation in docker bake with precedences)* Use ARG instead of `Dockerfile.${VARIANT}.node{10,12,14,16}` files* Use `SHELL ["/bin/bash", "-o", "pipefail", "-c"]` mode for Dockerfile* Specify version of Dockerfile avec v1 `#syntax=docker/dockerfile-upstream:1`* Reduce `RUN` steps* Upgrade tini to v0.19* Fix supercronic installation* Fix npm version built in slim mode* Add .dockerignore to optimise build time and memory
@mistralozmistralozforce-pushed thehotfix/multiarch branch 2 times, most recently from8c3a1de to61e03beCompareSeptember 19, 2022 16:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@mistraloz

[8]ページ先頭

©2009-2025 Movatter.jp