Install DMA
Make DMA configurable via environment variables
Document DMA usage &[NEW] add tests tobuild-and-test.sh
[NEW] Make sure the log output of DMA is redirected to STDERR by using busybox-syslogd (unfortunately DMA can only use syslog)

Explain themotivation for making this change. What existing problem does the pull request solve?

Most PHP hosters make the "mail()" function usable, so many PHP application expect it to be usable. With this image, those applications were unable to send email.

Test plan (required)

Seebuild-and-test.sh, the commands from there can also be run manually; the mails sent with the demo credentials can be viewed onhttps://ethereal.email/messages.

# Let's check that we can send mail directlyTESTMAIL_ID_DIRECT=$RANDOMdocker run --rm -e DMA_BLOCKING=1"thecodingmachine/php:${PHP_VERSION}-${BRANCH}-${BRANCH_VARIANT}" php -r"mail('lemuel.ratke46@ethereal.email', 'Hello World${TESTMAIL_ID_DIRECT}', 'This is an automatic test email, using a direct connection.');"# Let's check that we can send mail through a smarthost with credentials# Sending to an MCAST-TEST-NET IP address as that must not appear on the public internet according to RFC 5771, and will thus be unreachable for direct sending.TESTMAIL_ID_SMARTHOST=$RANDOMdocker run --rm -e DMA_BLOCKING=1 -e DMA_CONF_SMARTHOST=smtp.ethereal.email -e DMA_CONF_PORT=587 -e DMA_CONF_SECURETRANSFER= -e DMA_CONF_STARTTLS= -e DMA_AUTH_USERNAME=lemuel.ratke46@ethereal.email -e DMA_AUTH_PASSWORD=pjxG3kc3VR31jQUvHz"thecodingmachine/php:${PHP_VERSION}-${BRANCH}-${BRANCH_VARIANT}" php -r"mail('lemuel.ratke46@233.252.0.0', 'Hello World${TESTMAIL_ID_SMARTHOST}', 'This is an automatic test email, using a smarthost.');"# Let's check that the mails came throughETHEREAL_COOKIEJAR=$(mktemp --tmpdir ethereal-cookies.XXXXXXXXXX)ETHEREAL_CSRF=$(curl https://ethereal.email/login -s --fail -c"${ETHEREAL_COOKIEJAR}"| grep -Pom1'\bname="_csrf" value="\K[^"]+')curl https://ethereal.email/login -s --fail -X POST --data-urlencode"address=lemuel.ratke46@ethereal.email" --data-urlencode"password=pjxG3kc3VR31jQUvHz" --data-urlencode"_csrf=${ETHEREAL_CSRF}" -b"${ETHEREAL_COOKIEJAR}" -c"${ETHEREAL_COOKIEJAR}">/dev/nullETHEREAL_INBOX=$(curl https://ethereal.email/messages -s --fail -b"${ETHEREAL_COOKIEJAR}")rm"${ETHEREAL_COOKIEJAR}"echo"${ETHEREAL_INBOX}"| grep -F">Hello World${TESTMAIL_ID_DIRECT}<"echo"${ETHEREAL_INBOX}"| grep -F">Hello World${TESTMAIL_ID_SMARTHOST}<"

Closing issues

Fixes#204

Checklist

Have you followed the guidelines in ourCONTRIBUTING guide?
I have squashed any insignificant commits
This change has comments for package types, values, functions, and non-obvious lines of code

moqmar added5 commits

February 7, 2022 13:43

Install DMA & handle configuration variables (fixesthecodingmachine#204

cb71e1a

Add documentation for DMA

563bfea

Add busybox-syslogd to redirect DMA log output to STDERR

0a396bd

Fix missing AUTHPATH in dma.conf & add DMA_BLOCKING variable for testing

d9e7020

Fix manpage in documentation & add tests for DMA

4e7fdf9

Copy link

Author

FYI, I'm getting the same issue in the actions when runningPHP_VERSION="7.3" BRANCH="v4" VARIANT="cli" ./build-and-test.sh locally, also on the main v4 branch, so this doesn't look like it's an issue with these changes.

Copy link

Collaborator

mistraloz commentedFeb 8, 2022

First, thx you for your PR,@moqmar. I checked and seem a good implementation for all requirement.
About the fail of CI, it's seem related to an other issue !286 (i will wait this one can be fixed to merge this PR).

I may don't have time this week to manage this issue bug the reporter said he may fix it. If not, i will try to do it at end of next week.