Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refactorsunique_reskin, deletes retool kit#93775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
MrMelbert wants to merge10 commits intotgstation:master
base:master
Choose a base branch
Loading
fromMrMelbert:reskinrefactorin

Conversation

@MrMelbert
Copy link
Member

@MrMelbertMrMelbert commentedNov 3, 2025
edited
Loading

About The Pull Request

Closes#93635

unique_reskin is no longer a list on/item, now/datum/atom_skin

The actual reskinning behavior has been moved out to/datum/component/reskinable_item

PKC reskinning is now handled via alt-click reskin, rather than via the retooling kit. The retooling kit has been removed.
There's no limit on how many times you can reskin your PKC (though perhaps we limit it to one reskin and keep the retooling kit as a way to allow a miner to reskin it a second time?)

The Ashen Skull unique reskin is still a trophy, and instead unlocks its unique reskin option in the alt-click radial.

Why It's Good For The Game

I'm unsure why the retooling kit exists on its own, when it's relatively cheap and just performs the behavior of alt-click reskinning.

So to keep it consistent with all other forms of reskinning I've just made it baseline. To accomplish that I refactored reskinning.

The new form of reskinning allows for greater potential in adding reskins, allowing far more than just an icon state change. Also we can put it on turfs and mobs and structures now which is cool I guess

There's also the added benefit of being able to see an item's reskins without needing to instantiate it, which the loadout menu uses to great effect.

Changelog

🆑 Melbert
refactor: Refactored item reskinning (the alt-click way), report any oddities with that
del: Deleted the crusher retool kit, now you can just reskin your crusher with alt-click. The Skull skin is still locked behind having the Ashen Skull trophy applied.
fix: Stunswords no longer have an incorrect lore blurb
fix: Fixed loadout item reskinning's UI
/:cl:

theselfish reacted with thumbs up emoji
@github-actionsgithub-actionsbot added FixRewrites a bug so it appears in different circumstances RemovalThis was too fun, too fun! I'm turning this feature around RefactorMakes the code harder to read UIWe make the game less playable, but with round edges labelsNov 3, 2025
@1393F
Copy link
Contributor

Crusher trophy skins was consistent with KA skins, if you are changing them to use the reskinning function, you should also make the KAs use that too.

@MrMelbert
Copy link
MemberAuthor

MrMelbert commentedNov 3, 2025
edited
Loading

I always thought the expensive pka skins were a "prestige mechanic", which is why they were more expensive

However I am only now learning that they were literally only added to fill empty mod space. Except they don't fill space anymore.

theselfish reacted with thumbs up emoji

@theselfish
Copy link

I always thought the expensive pka skins were a "prestige mechanic", which is why they were more expensive

However I am only now learning that they were literally only added to fill empty mod space. Except they don't fill space anymore.

The real prestige would be a solid gold PKA skin that takes up 100% of mod volume.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@MothblocksMothblocksAwaiting requested review from MothblocksMothblocks is a code owner

@FikouFikouAwaiting requested review from FikouFikou is a code owner

@ExcessiveUseOfCobblestoneExcessiveUseOfCobblestoneAwaiting requested review from ExcessiveUseOfCobblestoneExcessiveUseOfCobblestone is a code owner

@stylemistakestylemistakeAwaiting requested review from stylemistake

Assignees

No one assigned

Labels

FixRewrites a bug so it appears in different circumstancesRefactorMakes the code harder to readRemovalThis was too fun, too fun! I'm turning this feature aroundUIWe make the game less playable, but with round edges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MrMelbert@1393F@theselfish

[8]ページ先頭

©2009-2025 Movatter.jp