- Notifications
You must be signed in to change notification settings - Fork1.3k
feat!: Add support for reserved_internal_range in secondary IP ranges#640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View thisfailed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the PR@mclavel
| ip_cidr_range=secondary_ip_range.value.ip_cidr_range | ||
| range_name=secondary_ip_range.value.range_name | ||
| ip_cidr_range=secondary_ip_range.value.ip_cidr_range | ||
| reserved_internal_range=secondary_ip_range.value.reserved_internal_range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Lets bump the min provider version to 6.0 when support for this field was added to the provider (for this and beta module)
https://github.com/hashicorp/terraform-provider-google/blob/main/CHANGELOG.md#600-august-26-2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ok 👍
examples/secondary_ranges/main.tf Outdated
| # Example of using reserved_internal_range instead of ip_cidr_range | ||
| # { | ||
| # range_name = "${local.subnet_03}-02" | ||
| # reserved_internal_range = "networkconnectivity.googleapis.com/projects/my-project/locations/global/internalRanges/my-range" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could we create this resource as part of the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done!
This PR adds support for the reserved_internal_range field in subnet secondary ranges