- Notifications
You must be signed in to change notification settings - Fork746
Migrate getEvaluationsForDatapoint to backend API#5273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
shuyangli wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+1,364 −374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
aaf8b2c to31a2441CompareMemberAuthor
shuyangli left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
next up need to produce typed outputs in evaluations
31a2441 to5ebf6f9Compare5ebf6f9 tofc34284Compare- Add EvaluationResultRow type and get_evaluations_for_datapoint method to EvaluationQueries trait- Implement ClickHouse query in db/clickhouse/evaluation_queries.rs- Add route handler at /internal/evaluations/datapoint- Add unit tests for database layer and route handler- Add e2e tests for database layer and route handler- Add getEvaluationsForDatapoint method to TensorZeroClient- Update evaluations.server.ts to use TensorZeroClient instead of direct ClickHouse queries- Remove unused getEvaluatorMetricName importUse generated typeTry to fix parse issuesFix JSON parsing and type errors in evaluation results consolidation- Add variant_name to JsonEvaluationResultSchema and ChatEvaluationResultSchema- Fix getEvaluationResults query to select variant_name- Remove redundant WithVariant schema types since base schemas now include variant_name- Fix type mismatches: convert undefined to null where components expect null- Fix EvaluationResultRow type usage in getEvaluationResults- Remove debug console.log statements and unused imports
fc34284 to3e45d8dCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
We should also change the API to return structured inputs and outputs instead of strings, but we'll do that separately.