- Notifications
You must be signed in to change notification settings - Fork746
Migrate getEvaluationRunInfosForDatapoint to backend#5258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
shuyangli wants to merge2 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+677 −86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
cc7fc00 to89dd786Compare3d40705 tobfe7b2dCompare- Add get_evaluation_run_infos_for_datapoint to EvaluationQueries trait- Implement ClickHouse query using TagInference table- Add route handler at /internal/evaluations/datapoints/{datapoint_id}/run-infos- Add unit tests with mocks for handler and database layer- Add e2e tests for endpoint and database queries- Update TensorZeroClient with new method- Update UI route to use TensorZeroClient- Remove unused getEvaluationRunInfosForDatapoint from evaluations.server.tsbfe7b2d to5188296CompareMemberAuthor
shuyangli commentedDec 18, 2025
/merge-queue |
Contributor
🚀 Merge queue workflow triggered! View the run:https://github.com/tensorzero/tensorzero/actions/runs/20351598805 |
Changed the query to match the old TypeScript version:- Added function_type parameter to determine inference table (ChatInference vs JsonInference)- Query now selects from inference table instead of TagInference- CTE no longer filters by function_name- Gets evaluation_run_id from tags column instead of TagInference valueRevert get_evaluation_run_infos_for_datapoint query to old patternChanged the query to match the old TypeScript version:- Added function_type parameter (FunctionConfigType) to determine inference table- Query now selects from inference table (ChatInference/JsonInference) instead of TagInference- CTE no longer filters by function_name- Gets evaluation_run_id from tags column instead of TagInference value- Gateway computes function_type from config instead of requiring it as query param- Handler validates function exists in config before querying
0268678 to24a3f89CompareMemberAuthor
shuyangli left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Restored the old SQL
Aaron1011 approved these changesDec 18, 2025
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Important
Migrate
getEvaluationRunInfosForDatapointto backend with new ClickHouse query and API endpoint, updating UI and tests accordingly.get_evaluation_run_infos_for_datapointtoEvaluationQueriestrait inevaluation_queries.rs.TagInferencetable inevaluation_queries.rs./internal/evaluations/datapoints/{datapoint_id}/run-infosinget_run_infos.rs.evaluation_queries.rsandget_run_infos.rs.evaluation_queries.rsandevaluations.rs.TensorZeroClientwithgetEvaluationRunInfosForDatapointmethod intensorzero.ts.TensorZeroClientinroute.tsx.getEvaluationRunInfosForDatapointfromevaluations.server.ts.This description was created by
for24a3f89. You cancustomize this summary. It will automatically update as commits are pushed.