- Notifications
You must be signed in to change notification settings - Fork74.9k
PR #32300: Support systemlib build of boringssl#101819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
copybara-service wants to merge1 commit intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+22 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Imported from GitHub PRopenxla/xla#32300📝 Summary of ChangesThis allows building XLA with a user-/system-provided version of boringssl/OpenSSL.🎯 JustificationWe use this in [conda-forge's packaging of `jaxlib`](https://github.com/conda-forge/jaxlib-feedstock) to unbundle the OpenSSL code from the jaxlib package and use the conda-provided `openssl` package. Thus, one can upgrade `openssl` without rebuilding `jaxlib`.🚀 Kind of Contribution✨ New FeatureCopybara import of the project:--80b0bada44d2817c62c6441d4c275cf5e79f4bca by Uwe L. Korn <uwe.korn@quantco.com>:Support systemlib build of boringsslMerging this changecloses#32300FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#32300 from xhochy:boringssl-systemlib 80b0bada44d2817c62c6441d4c275cf5e79f4bcaPiperOrigin-RevId: 816196521
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR#32300: Support systemlib build of boringssl
Imported from GitHub PRopenxla/xla#32300
📝 Summary of Changes
This allows building XLA with a user-/system-provided version of boringssl/OpenSSL.
🎯 Justification
We use this inconda-forge's packaging of
jaxlibto unbundle the OpenSSL code from the jaxlib package and use the conda-providedopensslpackage. Thus, one can upgradeopensslwithout rebuildingjaxlib.🚀 Kind of Contribution
✨ New Feature
Copybara import of the project:
--
80b0bada44d2817c62c6441d4c275cf5e79f4bca by Uwe L. Kornuwe.korn@quantco.com:
Support systemlib build of boringssl
Merging this changecloses#32300
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#32300 from xhochy:boringssl-systemlib 80b0bada44d2817c62c6441d4c275cf5e79f4bca