- Notifications
You must be signed in to change notification settings - Fork643
Adding parallelization to "tfq.convert_to_tensor" for performance (#336)#793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
redayzarra wants to merge3 commits intotensorflow:masterChoose a base branch fromredayzarra:parallelization
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Overview
Hi, this is a draft pull request for improving the
tfq.convert_to_tensorfunction by adding parallelization (#336). I'm confused about how the benchmarking suite works, so I am creating a draft pull request. For parallelization, I made sure to follow thePython documentation forconcurrent.futuresand usedProcessPoolExecutor.Since the
convert_itemfunction is mostly CPU-bound and doesn't require heavy communication between processes, usingProcessPoolExecutorshould provide a significant speed-up for large inputs.I have simply added parallelization to the
tfq.convert_to_tensorfunction and need help with benchmarking and testing.Changes
Parallelization: used
concurrent.futures.ProcessPoolExecutorto parallelize the conversion of items. Each item in the list is processed independently, which allows for significant speedup for converting large lists of items.Docstrings: the original function had informative docstrings that described the
tfq.convert_to_tensorfunction. I made sure to keep most of it and only added the necessary changes and fixed typos.Concerns
I wasn't able to benchmark my changes or run unit tests. I tried my best to follow theContribution guidelines but ran into a lot of errors with Bazel. I am still working on the issue and wanted to inform you that the code has not been benchmarked using theBenchmark guidelines.
If the function needs to handle extremely deep nested lists, the
convert_item()function may need to be iterative rather than recursive. However, the original author already made a comment to dismiss this concern.