- Notifications
You must be signed in to change notification settings - Fork1.8k
test: reduce the number of examples tests running in parallel#9114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
twoGiants left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
/approve
/lgtm
- `t.Parallel()` marks a test function, telling Go that it can be runin parallel with other functions in the same package.- `-parallel` determines "how many test functions inside a single testpackage can run in parallel".As all examples tests are using `t.Parallel()`, they all run inparallel. This might overwhelm the kind cluster a bit. This is makingsure we run at most 6 of them at the same time.It also removes the parents `t.Parallel()` as this is.. just weird.Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
7ffe7f7 to476f759Comparetekton-robot commentedNov 3, 2025
New changes are detected. LGTM label has been removed. |
afrittoli commentedNov 3, 2025
/retest |
afrittoli commentedNov 3, 2025
/approve |
tekton-robot commentedNov 3, 2025
[APPROVALNOTIFIER] This PR isAPPROVED This pull-request has been approved by:afrittoli,twoGiants The full list of commands accepted by this bot can be foundhere. The pull request process is describedhere Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
t.Parallel()marks a test function, telling Go that it can be runin parallel with other functions in the same package.
-paralleldetermines "how many test functions inside a single testpackage can run in parallel".
As all examples tests are using
t.Parallel(), they all run inparallel. This might overwhelm the kind cluster a bit. This is making
sure we run at most 6 of them at the same time.
It also removes the parents
t.Parallel()as this is.. just weird.Signed-off-by: Vincent Demeestervdemeest@redhat.com
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes