Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test: reduce the number of examples tests running in parallel#9114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
vdemeester wants to merge1 commit intotektoncd:main
base:main
Choose a base branch
Loading
fromvdemeester:e2e-limit-parallelism-in-examples

Conversation

@vdemeester
Copy link
Member

Changes

  • t.Parallel() marks a test function, telling Go that it can be run
    in parallel with other functions in the same package.
  • -parallel determines "how many test functions inside a single test
    package can run in parallel".

As all examples tests are usingt.Parallel(), they all run in
parallel. This might overwhelm the kind cluster a bit. This is making
sure we run at most 6 of them at the same time.

It also removes the parentst.Parallel() as this is.. just weird.

Signed-off-by: Vincent Demeestervdemeest@redhat.com

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • HasDocs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • HasTests included if any functionality added or changed
  • pre-commit Passed
  • Follows thecommit message standard
  • Meets theTekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples ofgood release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robottekton-robot added release-note-noneDenotes a PR that doesnt merit a release note. kind/miscCategorizes issue or PR as a miscellaneuous one. labelsOct 29, 2025
@tekton-robottekton-robot added the size/XSDenotes a PR that changes 0-9 lines, ignoring generated files. labelOct 29, 2025
Copy link
Member

@twoGiantstwoGiants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

/approve
/lgtm

@tekton-robottekton-robot added the lgtmIndicates that a PR is ready to be merged. labelOct 29, 2025
- `t.Parallel()` marks a test function, telling Go that it can be runin parallel with other functions in the same package.- `-parallel` determines "how many test functions inside a single testpackage can run in parallel".As all examples tests are using `t.Parallel()`, they all run inparallel. This might overwhelm the kind cluster a bit. This is makingsure we run at most 6 of them at the same time.It also removes the parents `t.Parallel()` as this is.. just weird.Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeestervdemeesterforce-pushed thee2e-limit-parallelism-in-examples branch from7ffe7f7 to476f759CompareNovember 3, 2025 09:07
@tekton-robottekton-robot removed the lgtmIndicates that a PR is ready to be merged. labelNov 3, 2025
@tekton-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@afrittoli
Copy link
Member

/retest

tekton-robot reacted with hooray emoji

@afrittoli
Copy link
Member

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR isAPPROVED

This pull-request has been approved by:afrittoli,twoGiants

The full list of commands accepted by this bot can be foundhere.

The pull request process is describedhere

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@tekton-robottekton-robot added the approvedIndicates a PR has been approved by an approver from all required OWNERS files. labelNov 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dibyomdibyomAwaiting requested review from dibyom

@jeropjeropAwaiting requested review from jerop

1 more reviewer

@twoGiantstwoGiantstwoGiants approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@twoGiantstwoGiants

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.kind/miscCategorizes issue or PR as a miscellaneuous one.release-note-noneDenotes a PR that doesnt merit a release note.size/XSDenotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vdemeester@tekton-robot@afrittoli@twoGiants

[8]ページ先頭

©2009-2025 Movatter.jp