Commit691b32a

committed

minor#17803 [Workflow] Improve Workflow Documentation (lamasfoker)

This PR was submitted for the 6.2 branch but it was squashed and merged into the 5.4 branch instead.Discussion----------[Workflow] Improve Workflow DocumentationAs you can see on the `MethodMarkingStore` [implementation](https://github.com/symfony/symfony/blob/v6.2.4/src/Symfony/Component/Workflow/MarkingStore/MethodMarkingStore.php#L64-L66), it checks if the `$marking` variable is `null` and not for empty `string` or empty `array`.So I suggest adding these changes to the Docu to declare it out of any doubt. I notice these also on the workflow demo by `@lyrixx`, specifically [here](https://github.com/lyrixx/SFLive-Paris2016-Workflow/blob/master/src/Entity/Article.php#L15-L16) and [here](https://github.com/lyrixx/SFLive-Paris2016-Workflow/blob/master/src/Entity/Task.php#L15-L16).Commits-------85ed54b [Workflow] Improve Workflow Documentation

2 parentse7ec633 +85ed54b commit691b32aCopy full SHA for 691b32a

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,10 @@ The configured property will be used via its implemented getter/setter methods b`
`194`	`194`	`preferable to not configure it.`
`195`	`195`
`196`	`196`	A single state marking store uses a ``string`` to store the data. A multiple
`197`		- state marking store uses an ``array`` to store the data.
	`197`	+ state marking store uses an ``array`` to store the data. On both cases if no
	`198`	+ state marking store is defined you have to return ``null``. So in the above
	`199`	+ example should be defined a return type like ``App\Entity\BlogPost::getCurrentPlace(): ?array``
	`200`	+ or like ``App\Entity\BlogPost::getCurrentPlace(): ?string``.
`198`	`201`
`199`	`202`	`..tip::`
`200`	`203`

Comments

(0)