Commit5f1dda8

committed

bug#20403 [Security] Fix wrong method call of the decision manager (Oliver Kossin)

This PR was merged into the 5.4 branch.Discussion----------[Security] Fix wrong method call of the decision manager`@xabbuh` changed the use of “decision manage” in [PR-20388](#20388) However, the method is described differently in the [interface](https://github.com/symfony/symfony/blob/7.2/src/Symfony/Component/Security/Core/Authorization/AccessDecisionManagerInterface.php#L29).It's not `isGranted` its `decide`Commits-------97599f7 Fix isGranted to decide

2 parents6c5aa0b +97599f7 commit5f1dda8Copy full SHA for 5f1dda8

File tree

-3

lines changed

-3

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -337,12 +337,12 @@ logic you want::`
`337`	`337`	`}`
`338`	`338`
`339`	`339`	`// you can still check for ROLE_ALLOWED_TO_SWITCH`
`340`		`- if ($this->accessDecisionManager->isGranted($token, ['ROLE_ALLOWED_TO_SWITCH'])) {`
	`340`	`+ if ($this->accessDecisionManager->decide($token, ['ROLE_ALLOWED_TO_SWITCH'])) {`
`341`	`341`	`return true;`
`342`	`342`	`}`
`343`	`343`
`344`	`344`	`// check for any roles you want`
`345`		`- if ($this->accessDecisionManager->isGranted($token, ['ROLE_TECH_SUPPORT'])) {`
	`345`	`+ if ($this->accessDecisionManager->decide($token, ['ROLE_TECH_SUPPORT'])) {`
`346`	`346`	`return true;`
`347`	`347`	`}`
`348`	`348`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -248,7 +248,7 @@ with ``ROLE_SUPER_ADMIN``::
`248`	`248`	`// ...`
`249`	`249`
`250`	`250`	`// ROLE_SUPER_ADMIN can do anything! The power!`
`251`		`- if ($this->accessDecisionManager->isGranted($token, ['ROLE_SUPER_ADMIN'])) {`
	`251`	`+ if ($this->accessDecisionManager->decide($token, ['ROLE_SUPER_ADMIN'])) {`
`252`	`252`	`return true;`
`253`	`253`	`}`
`254`	`254`

Comments

(0)