Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[OptionsResolver] Allow deprecations to be overridden with an empty s…#62345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
yoeunes wants to merge1 commit intosymfony:6.4Choose a base branch fromyoeunes:options-resolver-deprecation-override
base:6.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+40 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
yceruto commentedNov 8, 2025
I'm not sold by this change. Could you elaborate a bit more on when this would be useful? |
Member
yceruto commentedNov 8, 2025
It looks to me like a new feature intended to remove a deprecation notice. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that prevented a previously set deprecation from being cancelled. If
setDeprecated()was called with an empty string, it would returnvoidwithout removing the existing deprecation entry.This made it impossible for child classes or subsequent configurations to override and disable a deprecation set by a parent configuration.
The fix ensures that calling
setDeprecated('...', '')activelyunset()s the deprecation from the internal array, restoring the expected override behavior.Example:
Given a base configuration (e.g., a parent class) that deprecates the
hostnameoption, based on the documentation's example:A child configuration attempts toannul this deprecation:
Before (The Bug):
The
isDeprecated('hostname')method still returnedtrue, and resolving['hostname' => '...']would incorrectly trigger anE_USER_DEPRECATEDerror.After (The Fix):
The deprecation is correctly removed.
isDeprecated('hostname')now returnsfalse, and no deprecation error is triggered when resolving the option.