Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[OptionsResolver] Fix missing prototype key in nested error paths#62344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
yoeunes wants to merge1 commit intosymfony:6.4Choose a base branch fromyoeunes:options-resolver-nested-prototype-path-6.4
base:6.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[OptionsResolver] Fix missing prototype key in nested error paths#62344
yoeunes wants to merge1 commit intosymfony:6.4fromyoeunes:options-resolver-nested-prototype-path-6.4
+47 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
MissingOptionsExceptionerror messages for nested prototypes generated an incomplete path. When an option was missing inside a prototype that wasitself nested inside another prototype, the key of the parent prototype was omitted from the error message.The fix ensures the parent's prototype index is correctly tracked and prepended when resolving nested options, providing a full and accurate path for easier debugging.
Example:
Given the following nested prototype setup:
And this configuration, which is missing a
hostinmain_db's second replica:Before (The Bug):
The exception message was incorrect, missing the
main_dbkey:The required option "connections[replicas][1][host]" is missing.After (The Fix):
The exception message is now correct and includes the full path:
The required option "connections[main_db][replicas][1][host]" is missing.A test case (
testNestedPrototypeErrorPathHasFullContext) has been added to cover this scenario and prevent regressions.