Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Add#[AsVoter] attribute to configure voter priority#62341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ayyoub-afwallah wants to merge1 commit intosymfony:7.4Choose a base branch fromayyoub-afwallah:feature/add-asVoter-attribute
base:7.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[Security] Add#[AsVoter] attribute to configure voter priority#62341
ayyoub-afwallah wants to merge1 commit intosymfony:7.4fromayyoub-afwallah:feature/add-asVoter-attribute
+282 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
28fda6f to4fda52cCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
#[AsVoter]attribute that allows security voters to declare their priority directly within the class, as proposed in issue#43074.Motivation
While
#[AsTaggedItem]or#[Autoconfigure]can technically set voter priority, they require manually specifying tag names and options, making the configuration verbose, error-prone, and less intuitive.The goal of
#[AsVoter]is to simplify voter configuration and make it explicit, intuitive, and easy to use, following the pattern of other Symfony attributes such as#[AsEventListener].The
#[AsVoter]attribute provides:#[AsCommand],#[AsEventListener],#[AsMessageHandler], etc.Behavior
#[AsVoter]attribute overrides YAML configuration and other attributes (#[AsTaggedItem]#[Autoconfigure])Before
After