Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Deprecate default index/priority methods when defining tagged locators/iterators#62339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Conversation
…efining tagged locators/iterators
| } | ||
| if (!\is_array($exclude)) { | ||
| if (false ===$defaultIndexMethod) { | ||
| $defaultIndexMethod =$exclude; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why this case ?$exclude is not in the position of the old$defaultIndexMethod
2677a0a to9b40d76Comparenicolas-grekas commentedNov 7, 2025
Status: needs work The last commit fixes the tests but needs close review / refactoring of mine (it's LLM generated for now) |
stof commentedNov 7, 2025
I don't think the amount of code simplification brought by that feature is worth adding new deprecations so late in the process. |
I'm targeting 7.4 because this might be a last-minute deprecation we'd like to do.
The first commit is#62329
The second commit is deprecating
getDefaultFooName()methods and$defaultIndexMethodarguments used to build tagged iterators/locators (and alike for priorities).These have been supersceded by
#[AsTaggedItem]attributes, which are available since Symfony 5.3.It was about time. Deprecating these will reduce complexity of the code, and of the doc!