NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[Translation] Relax version constraint for contracts#62336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

nicolas-grekas wants to merge1 commit intosymfony:8.0fromnicolas-grekas:tr-ctrct

Closed

[Translation] Relax version constraint for contracts#62336

nicolas-grekas wants to merge1 commit intosymfony:8.0fromnicolas-grekas:tr-ctrct

+1 −1

Conversation

Copy link

Member

nicolas-grekas commentedNov 7, 2025

Q	A
Branch?	8.0
Bug fix?	no
New feature?	no
Deprecations?	no
Issues	https://github.com/symfony/symfony/pull/61182/files#r2500627687
License	MIT

Looks like the bump was too aggressive.

nicolas-grekas requested a review fromwelcoMattic as acode owner

November 7, 2025 08:31

carsonbot added Status: Needs Review Translation labels

Nov 7, 2025

carsonbot added this to the8.0 milestone

Nov 7, 2025

nicolas-grekas mentioned this pull request

Nov 7, 2025

[Translation] RemoveTranslatableMessage::__toString() method, usetrans() orgetMessage() instead#61182

Merged

nicolas-grekas changed the title~~[Translation] Relax version constrainst for contracts~~[Translation] Relax version constraint for contracts

Nov 7, 2025

[Translation] Relax version constraint for contracts

0bcc642

nicolas-grekas force-pushed thetr-ctrct branch from4c66f25 to0bcc642Compare

November 7, 2025 08:32

stof approved these changes

Nov 7, 2025

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Nov 7, 2025

VincentLanglet mentioned this pull request

Nov 7, 2025

Add Symfony 8 supportBehat/Behat#1687

Open

xabbuh requested changes

Nov 7, 2025

View reviewed changes

Copy link

Member

xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the low deps failure looks related

carsonbot added Status: Needs Work and removed Status: Reviewed labels

Nov 7, 2025

Copy link

Member

stof commentedNov 7, 2025

I think we need to require^3.6.0 because older versions don't support PHPUnit 10+ in their test cases (that's the reason for all the failures about missing arguments, as PHPUnit 11 does not support@dataProvider annotations anymore).

and for the test failing for TranslatableInterface in the global parameters, I think it might be a legitimate reason to use 3.6.1 as lowest bound to have that fix available:symfony/translation-contracts@3a74934
But this means we need to release that fix.

Copy link

Member

xabbuh commentedNov 7, 2025

I had a deeper look. For PHPUnit 12 compatibility we need#58182 (released in 3.6.0). For the then remaining test failure we need#61111 which isn't released yet.