Movatterモバイル変換

Skip to content

symfony/symfonyPublic

NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[Routing] Fix default value not taken if usigng name:entity.attribute#62325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

eltharin wants to merge3 commits intosymfony:7.3

base:7.3

Choose a base branch

fromeltharin:error_default_route_argument_with_complete_notation

Open

[Routing] Fix default value not taken if usigng name:entity.attribute#62325

eltharin wants to merge3 commits intosymfony:7.3fromeltharin:error_default_route_argument_with_complete_notation

+19 −4

Conversation

@eltharin

Copy link

Contributor

eltharin commentedNov 6, 2025

Q	A
Branch?	7.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

When using Mapped parameters, default values can't be used :

    #[Route('/zoom/{vortexLibelle:vortex.libelle}/{libelle:otherVortex}', name:'zoom', methods: ['GET'])]    #[AjaxCallOrNot]publicfunctionzoom(VortexManager$vr,Vortex$vortex, ?Vortex$otherVortex =null):Response    {...    }

or

    #[Route('/zoom/{vortexLibelle:vortex.libelle}/{otherVortexLibelle:otherVortex.libelle}', name:'zoom', methods: ['GET'])]    #[AjaxCallOrNot]publicfunctionzoom(VortexManager$vr,Vortex$vortex, ?Vortex$otherVortex =null):Response    {...    }

route was not found if we want to go to : /zoom/myVortex,

with this fix, it's OK

@eltharin

correct bug for default value not taken if usigng name:entity.attribute

4da1d65

@carsonbot

carsonbot added Status: Needs Review Bug labels

@carsonbot

carsonbot added this to the7.3 milestone

@carsonbot

carsonbot changed the title~~correct bug for default value not taken if usigng name:entity.attribute~~ correct bug for default value not taken if usigng name:entity.attribute

@xabbuh

xabbuh added the Routing label

@carsonbot

carsonbot changed the title ~~correct bug for default value not taken if usigng name:entity.attribute~~[Routing] correct bug for default value not taken if usigng name:entity.attribute

@eltharin

eltharin changed the title~~[Routing] correct bug for default value not taken if usigng name:entity.attribute~~[Routing] Fix default value not taken if usigng name:entity.attribute

nicolas-grekas

nicolas-grekas reviewed

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

what about the logic for backed enums in the previous block? don't we need something similar?

src/Symfony/Component/Routing/Loader/AttributeClassLoader.php OutdatedShow resolvedHide resolved

@eltharin

update for all in one pregmatch

f5077aa

@eltharin

eltharin force-pushed theerror_default_route_argument_with_complete_notation branch from6a89ac7 tof5077aaCompare

November 6, 2025 16:28

@eltharin

Copy link

ContributorAuthor

eltharin commentedNov 6, 2025•
edited
Loading

I write on my todolist to allow mapped parameters notation to use BackedEnum::from :)

nicolas-grekas

nicolas-grekas reviewed

View reviewed changes

src/Symfony/Component/Routing/Loader/AttributeClassLoader.php OutdatedShow resolvedHide resolved

@eltharin

change end car

613acce

@eltharin

eltharin force-pushed theerror_default_route_argument_with_complete_notation branch froma916fc7 to613acceCompare

November 6, 2025 16:43

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

Bug Routing Status: Needs Review

4 participants

@eltharin

@nicolas-grekas

@xabbuh

@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp