Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config] Add getter of definition nodes properties#62122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Conversation
b34371c to4a2271eCompare| $nullableBooleanNode->setDefaultValue(null); | ||
| yield [$nullableBooleanNode,'bool|null']; | ||
| yield [newBooleanNode('node', nullable:true),'bool|null']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please don't use named parameters. They are not covered by BC. Using the public API in tests can help detect some unintended BC breaks (if we have to edit those tests for unrelated reasons)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you update this occurrence, could you also please fix the other ones in the provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Updated, please note the inconsistency in the constructor signature. ThepathSeparator is before node-specific options inBooleanNode but after inIntegerNode
| * | ||
| * @return list<array{0: mixed, 1: mixed}> | ||
| */ | ||
| publicfunctiongetEquivalentValues():array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This one may not be necessary.
Uh oh!
There was an error while loading.Please reload this page.
Inb68f0e6, the methods
NumericNode::getMin()etNumericNode::getMax()have been added so that they can be used to generate the array shape.Other getters would be necessary for the
JsonSchemagenerator (#59620)BaseNode::getEquivalentValues()indicate ifnull,true,falseare allowed valuesBooleanNode::isNullable()indicates ifnullis an allowed valueVariableNode::getAllowEmptyValue()indicates if an empty string is allowed