NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DependencyInjection][Routing] Remove support for the XML configuration format#61930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:8.0fromnicolas-grekas:drop-xml-config

Oct 3, 2025

Merged

[DependencyInjection][Routing] Remove support for the XML configuration format#61930

fabpot merged 1 commit intosymfony:8.0fromnicolas-grekas:drop-xml-config

Oct 3, 2025

Conversation

Copy link

Member

nicolas-grekas commentedOct 2, 2025

Q	A
Branch?	8.0
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	-
License	MIT

Per#60568

nicolas-grekas requested review fromchalasr andyceruto ascode owners

October 2, 2025 13:39

carsonbot added Status: Needs Review DependencyInjection Feature Routing labels

Oct 2, 2025

carsonbot added this to the8.0 milestone

Oct 2, 2025

nicolas-grekas force-pushed thedrop-xml-config branch 2 times, most recently from1298bce tobc43f76Compare

October 2, 2025 14:44

stof reviewed

Oct 2, 2025

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/BuildDebugContainerTrait.php

		$locatorPass =newServiceLocatorTagPass();
		$locatorPass->process($container);
		}
		$dumpedContainer =unserialize(file_get_contents(substr_replace($file,'.ser', -4)));

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suggest changing the value ofdebug.container.dump to have a file name ending in.ser directly instead of keeping a.xml path while the XML file won't exist.

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd keep the param as is: the xml file still exists and is dumped e.g. for IDE plugins

src/Symfony/Component/Routing/Tests/RouteCollectionTest.phpShow resolvedHide resolved

nicolas-grekas mentioned this pull request

Oct 2, 2025

Ensure branch 7.4 will remain compatible with 8.0 once XML loaders are removed#61931

Merged

yceruto approved these changes

Oct 2, 2025

View reviewed changes

Copy link

Member

yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Oct 2, 2025

nicolas-grekas added a commit that referenced this pull request

Oct 2, 2025

minor#61931Ensure branch 7.4 will remain compatible with 8.0 once X…

fd841c3

…ML loaders are removed (nicolas-grekas)This PR was merged into the 7.4 branch.Discussion---------- Ensure branch 7.4 will remain compatible with 8.0 once XML loaders are removed| Q             | A| ------------- | ---| Branch?       | 7.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITAfter#60568Needed for#61930Commits-------758c7f5 Ensure branch 7.4 will remain compatible with 8.0 once XML loaders are removed

[DependencyInjection][Routing] Remove support for the XML configurati…

af1f030

…on format

nicolas-grekas force-pushed thedrop-xml-config branch frombc43f76 toaf1f030Compare

October 2, 2025 15:17

Copy link

MemberAuthor

nicolas-grekas commentedOct 2, 2025

PR ready, failures unrelated

Copy link

Contributor

ro0NL commentedOct 2, 2025

does this also include the removal of var/cache/env/*Container.xml?

Copy link

MemberAuthor

nicolas-grekas commentedOct 2, 2025

It doesn't (see#61930 (comment))

Copy link

Contributor

ro0NL commentedOct 2, 2025•
edited
Loading

so IIUC we preserve XML format on that location for the future?

Copy link

MemberAuthor

nicolas-grekas commentedOct 2, 2025

Correct, see#61280

Copy link

Contributor

ro0NL commentedOct 2, 2025•
edited
Loading

im struggling why we couldnt maintain the format then for every day config, personally i dont mind lack of xsd valition nor requiring ext-dom (in userland)

Copy link

MemberAuthor

nicolas-grekas commentedOct 2, 2025

The discussion happened in#60568

Copy link

Contributor

ro0NL commentedOct 2, 2025

Let's wait on the discussion on the issue to know what should actually be deprecated. This PR deprecates a lot more than what was mentioned in the issue it fixes.

I am not really sure we need to go thus far.

But if someone likes using XML config files, why shouldn't we allow it optionally if the maintenance overhead is barely measurable?

I have a hard time following this initiative to be honest.

Copy link

MemberAuthor

nicolas-grekas commentedOct 2, 2025

This is really not helping@ro0NL, please do your part, this is burning my good will.
The discussion goes on to reduce the scope - that comment you copy/pasted is related to a previous iteration of the PR, you can see that from the rest of the discussion.