NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[HttpCache][WIP] Use RFC9211 Cache-Status#60078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

franckranaivo wants to merge4 commits intosymfony:7.4

base:7.4

Choose a base branch

fromfranckranaivo:58985-httpcache-rfc9211-compliancy

Draft

[HttpCache][WIP] Use RFC9211 Cache-Status#60078

franckranaivo wants to merge4 commits intosymfony:7.4fromfranckranaivo:58985-httpcache-rfc9211-compliancy

+6 −0

Conversation

Copy link

Contributor

franckranaivo commentedMar 28, 2025•
edited by OskarStark
Loading

Q	A
Branch	7.3
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	#58985
License	MIT

This PR is intended to answer#58985 by using Cache-Status directives as describedhere.

From now it is still a work in progress. Very basic feature were added in this first commit with a naïve implementation to see if am on the right track.

[WIP] Add cache status hit headers if fresh cache

ef42804

carsonbot added Status: Needs Review Feature labels

Mar 28, 2025

carsonbot added this to the7.3 milestone

Mar 28, 2025

franckranaivo marked this pull request as draft

March 28, 2025 16:49

OskarStark reviewed

Mar 30, 2025

View reviewed changes

src/Symfony/Component/HttpFoundation/HeaderBag.php OutdatedShow resolvedHide resolved

src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTest.php OutdatedShow resolvedHide resolved

fabpot modified the milestones:7.3,7.4

May 26, 2025

Copy link

Member

stof commentedJun 23, 2025

@franckranaivo do you intend to continue this ?

Btw, it would be great to update the description of the PR to include some usage examples. It makes the review much easier.

stof reviewed

Jun 23, 2025

View reviewed changes

src/Symfony/Component/HttpFoundation/HeaderBag.php

		protectedarray$headers = [];
		protectedarray$cacheControl = [];

		protectedarray$cacheStatus = [];

Copy link

Member

stofJun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this array is unused

Copy link

ContributorAuthor

franckranaivoJun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yes, I intended to use this array later in order to separate cache status headers (in the rfc) from cache control headers. It is still a wip, but yes soon it will be used.