This PR adds a--platform node|browser [default: browser] argument that lets you control this behaviour. In case ofnode it will generate ainit function that callsdefaultNodeSetup instead ofdefaultBrowserSetup.

t089 added7 commits

October 18, 2025 09:34

adds a --platform flag to js to control the target platform of the ge…

f60bfd6

…nerated code

Improve template code to better support node

fa6e321

1. Fixed missing type export (platforms/node.d.ts)   - Exported DefaultNodeSetupOptions type that is referenced in index.js2. Updated index.d.ts to support both platforms   - Made init() function accept DefaultNodeSetupOptions for node platform   - Made init() function accept Options for browser platform3. Fixed conditional compilation in node.js   - Wrapped getImports() in HAS_IMPORTS conditional (platforms/node.js)

Add devDependency @types/node so TypeScript can understand Node.js APIs

c3c3424

run tscCheck on preprocessed templates

eed636d

test both browser and node platform variants

update snapshot salts

a1b912b

Merge branch 'main' into platform-arg

e56a81e

add Plugin/PackageToJS/Templates to bootstrap

83b31fa

MaxDesiatov reviewed

Oct 20, 2025

View reviewed changes

Plugins/PackageToJS/Sources/PackageToJS.swift Outdated

		/// Name of the package (default: lowercased Package.swift name)
		varpackageName:String?
		/// Target platform for the generated JavaScript (default: browser)
		varplatform:String?

Copy link

Member

MaxDesiatovOct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could this become anenum Platform: CaseIterable, so then you would rely on.allCases to dynamically compute help string for all available platforms in the help output you've added below for this new option?

Copy link

ContributorAuthor

t089Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sounds good! Will do

Copy link

Member

MaxDesiatov commentedOct 20, 2025

Please run./Utilities/format.py for the formatting check to pass.

MaxDesiatov added enhancement

New feature or request

dependenciesPull requests that update a dependency file labels

Oct 20, 2025

t089 added2 commits

October 20, 2025 17:42

formatting

4e8bc2f

modelplatform as enum

76ee898

MaxDesiatov changed the title~~Draft: adds a --platform flag to js~~Draft: add--platform option topackage js

Oct 20, 2025

MaxDesiatov changed the title~~Draft: add--platform option topackage js~~Add--platform option topackage js

Oct 20, 2025

Copy link

Member

MaxDesiatov commentedOct 20, 2025•
edited
Loading

Thanks for the updates! Cleaned up the title:

"Draft" in the title is not needed, as "Draft" status of PRs already makes that clear.
We use infinitive form of verbs in PR and commit titles, as with character limit in this field non-infinitive forms don't bring any useful information.
--platform is not a flag, as flags denote binary state and don't take any parameters. E.g.--enable-platform/--disable-platform without any parameters would be a flag, but--platform node/--platform browser is an option. If we were able to use Swift Argument Parser in plugins, this would use the@Option property wrapper.

use browser as default value for platform

27dadd9

kateinoigakukun reviewed

Oct 20, 2025

View reviewed changes

Copy link

Member

kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for putting your effort here! Overall it makes sense to me!

Let me leave a few feedbacks before mering:

I'd like to keep the generated JS package to be runtime independent as much as possible, so it might be better to name the option as--default-platform, indicating that only the default entrypointindex.js is platform dependent, and rest of the modules are still platform independent. The clarification would be partuculary helpful for library author publishing a platform-agnostic JS package containing the JSKit genrated code.
I'm not a big fan of adding@types/node dependency here because we use only small surface of Node.js API, and most of the usage is not visible from users (except forWorker type). I think we can loosen type checks in the Node.js for the sake of the simplicity.

If that sounds reasonable, I can make changes on the top of your branch and merge this PR :)