- Notifications
You must be signed in to change notification settings - Fork208
Windows: Make sure the URL is fully formed before attempting to download#493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Please also update other windows Dockerfiles too. |
| # Install Swift toolchain. | ||
| ARG SWIFT_RELEASE_METADATA=https://download.swift.org/development/windows10/latest-build.json | ||
| RUN $Release = curl.exe -sL ${env:SWIFT_RELEASE_METADATA} | ConvertFrom-JSON; \ | ||
| Write-Host ('({0})' -f $Release); \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This will dump the json to the console - fine for debugging, but shouldn't be committed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@compnerd Are there any concerns about dumping the JSON file to the console? The JSON file is just a few lines long. I’m intentionally doing this so that if there are any failures, we can see what it contained and help us understand why it doesn’t contain the expected values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It makes it harder to see what is going on. If you want to do this at the end of the run if there are failures, that is fine, but we shouldn't do this in all cases IMO.
This should prevent the 404 errors when the URL is malformed due to`dir` and `download` fields missing.
Done! |
This should prevent the 404 errors when the URL is malformed due to
diranddownloadfields missing.