- Notifications
You must be signed in to change notification settings - Fork208
Install binaries under$SWIFT_PREFIX/usr/bin instead of/usr/bin#455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
kkebo wants to merge3 commits intoswiftlang:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
984462a tofd82e29Compare0628abe to6902af9Compare6902af9 to0225a99Compare79a75a3 to1eba53fCompareI updated the branch and added the changes for the new nightly-6.2 directory. |
1eba53f to6eecf3bCompare6eecf3b to4226312CompareThis prevents some binaries from being unintentionally overwritten by the system package manager. Symbolic links are also placed in the old directory (`/usr/bin`) for compatibility.
…/bin`This prevents some binaries from being unintentionally overwritten by the system package manager. Symbolic links are also placed in the old directory (`/usr/bin`) for compatibility.
…/bin`This prevents some binaries from being unintentionally overwritten by the system package manager. Symbolic links are also placed in the old directory (`/usr/bin`) for compatibility.
4226312 toc3797c7CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Motivation
fixes#383
This prevents some binaries from being unintentionally overwritten by the system package manager.
Changes
I added the following changes to 6.0 Dockerfiles, 6.1 Dockerfiles, nightly-6.1 Dockerfiles, nightly-6.2 Dockerfiles, and nightly-main Dockerfiles.
$SWIFT_PREFIXinstead of/$SWIFT_PREFIXis/opt/swift/{version number}by default.PATH="${SWIFT_PREFIX}/usr/bin:${PATH}"andLD_LIBRARY_PATH="${SWIFT_PREFIX}/usr/lib/swift/linux"$SWIFT_PREFIX/usr/bin/*to/usr/bin/*for existing users who expectswiftto be in/usr/bin.