Commitbd34e9f

authored

feat: remove duplicatedgcd-like functions (TheAlgorithms#1642)

* feat: remove duplicated `gcd`-like functions* Updated Documentation in README.md---------Co-authored-by: vil02 <vil02@users.noreply.github.com>

1 parent0204198 commitbd34e9fCopy full SHA for bd34e9f

File tree

+46

-55

lines changed

+46

-55

lines changed

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,6 @@`
`260`	`260`	`*[SquareRootLogarithmic](Maths/SquareRootLogarithmic.js)`
`261`	`261`	`*[SumOfDigits](Maths/SumOfDigits.js)`
`262`	`262`	`*[SumOfGeometricProgression](Maths/SumOfGeometricProgression.js)`
`263`		`-*[TwinPrime](Maths/TwinPrime.js)`
`264`	`263`	`*[TwoSum](Maths/TwoSum.js)`
`265`	`264`	`*[Volume](Maths/Volume.js)`
`266`	`265`	`*[WhileLoopFactorial](Maths/WhileLoopFactorial.js)`
`@@ -296,7 +295,6 @@`
`296`	`295`	`*Recursive`
`297`	`296`	`*[BinaryEquivalent](Recursive/BinaryEquivalent.js)`
`298`	`297`	`*[BinarySearch](Recursive/BinarySearch.js)`
`299`		`-*[EucledianGCD](Recursive/EucledianGCD.js)`
`300`	`298`	`*[Factorial](Recursive/Factorial.js)`
`301`	`299`	`*[FibonacciNumberRecursive](Recursive/FibonacciNumberRecursive.js)`
`302`	`300`	`*[FloodFill](Recursive/FloodFill.js)`

Lines changed: 23 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,13 +1,17 @@`
	`1`	`+functionCheckInput(a,b){`
	`2`	`+if(typeofa!=='number'\|\|typeofb!=='number'){`
	`3`	`+thrownewTypeError('Arguments must be numbers')`
	`4`	`+}`
	`5`	`+}`
	`6`	`+`
`1`	`7`	`/**`
`2`	`8`	`* GetEuclidGCD Euclidean algorithm to determine the GCD of two numbers`
`3`	`9`	`*@param {Number} a integer (may be negative)`
`4`	`10`	`*@param {Number} b integer (may be negative)`
`5`	`11`	`*@returns {Number} Greatest Common Divisor gcd(a, b)`
`6`	`12`	`*/`
`7`	`13`	`exportfunctionGetEuclidGCD(a,b){`
`8`		`-if(typeofa!=='number'\|\|typeofb!=='number'){`
`9`		`-thrownewTypeError('Arguments must be numbers')`
`10`		`-}`
	`14`	`+CheckInput(a,b)`
`11`	`15`	`a=Math.abs(a)`
`12`	`16`	`b=Math.abs(b)`
`13`	`17`	`while(b!==0){`
`@@ -17,3 +21,19 @@ export function GetEuclidGCD(a, b) {`
`17`	`21`	`}`
`18`	`22`	`returna`
`19`	`23`	`}`
	`24`	`+`
	`25`	`+/**`
	`26`	`+ * Recursive version of GetEuclidGCD`
	`27`	`+ *@param {Number} a integer (may be negative)`
	`28`	`+ *@param {Number} b integer (may be negative)`
	`29`	`+ *@returns {Number} Greatest Common Divisor gcd(a, b)`
	`30`	`+ */`
	`31`	`+exportfunctionGetEuclidGCDRecursive(a,b){`
	`32`	`+CheckInput(a,b)`
	`33`	`+a=Math.abs(a)`
	`34`	`+b=Math.abs(b)`
	`35`	`+if(b==0){`
	`36`	`+returna`
	`37`	`+}`
	`38`	`+returnGetEuclidGCDRecursive(b,a%b)`
	`39`	`+}`

Lines changed: 23 additions & 20 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,22 +1,25 @@`
`1`		`-import{GetEuclidGCD}from'../GetEuclidGCD'`
	`1`	`+import{GetEuclidGCD,GetEuclidGCDRecursive}from'../GetEuclidGCD'`
`2`	`2`
`3`		`-describe('GetEuclidGCD',()=>{`
`4`		`-it.each([`
`5`		`-[5,20,5],`
`6`		`-[109,902,1],`
`7`		`-[290,780,10],`
`8`		`-[104,156,52],`
`9`		`-[0,100,100],`
`10`		`-[-5,50,5],`
`11`		`-[0,0,0],`
`12`		`-[1,1234567,1]`
`13`		`-])('returns correct result for %i and %j',(inputA,inputB,expected)=>{`
`14`		`-expect(GetEuclidGCD(inputA,inputB)).toBe(expected)`
`15`		`-expect(GetEuclidGCD(inputB,inputA)).toBe(expected)`
`16`		`-})`
	`3`	`+describe.each([GetEuclidGCD,GetEuclidGCDRecursive])(`
	`4`	`+'%# GetEuclidGCD',`
	`5`	`+(gcdFunction)=>{`
	`6`	`+it.each([`
	`7`	`+[5,20,5],`
	`8`	`+[109,902,1],`
	`9`	`+[290,780,10],`
	`10`	`+[104,156,52],`
	`11`	`+[0,100,100],`
	`12`	`+[-5,50,5],`
	`13`	`+[0,0,0],`
	`14`	`+[1,1234567,1]`
	`15`	`+])('returns correct result for %i and %j',(inputA,inputB,expected)=>{`
	`16`	`+expect(gcdFunction(inputA,inputB)).toBe(expected)`
	`17`	`+expect(gcdFunction(inputB,inputA)).toBe(expected)`
	`18`	`+})`
`17`	`19`
`18`		`-it('should throw when any of the inputs is not a number',()=>{`
`19`		`-expect(()=>GetEuclidGCD('1',2)).toThrowError()`
`20`		`-expect(()=>GetEuclidGCD(1,'2')).toThrowError()`
`21`		`-})`
`22`		`-})`
	`20`	`+it('should throw when any of the inputs is not a number',()=>{`
	`21`	`+expect(()=>gcdFunction('1',2)).toThrowError()`
	`22`	`+expect(()=>gcdFunction(1,'2')).toThrowError()`
	`23`	`+})`
	`24`	`+}`
	`25`	`+)`

Lines changed: 0 additions & 30 deletions

This file was deleted.

Comments

(0)