Aug 27, 2024 · Aug 28, 2024 · Aug 28, 2024 · Aug 28, 2024
diff --git a/docs/preprocessing.md b/docs/preprocessing.md
        /** Add a custom language preprocessor */
        potatoLanguage({ content, filename, attributes }) {
          const { code, map } = require('potato-language').render(content);
          const { src, ...cleanedAttributes } = attributes;

          return { code, map };
          return { code, map, attributes: cleanedAttributes };
        },
      }),
    }),
diff --git a/src/modules/tagInfo.ts b/src/modules/tagInfo.ts
    markup,
  };
 };

 export const removeSrcAttribute = (attributes: Record<string, any>) => {
  const { src, ...rest } = attributes;

  return rest;
 };
diff --git a/src/processors/babel.ts b/src/processors/babel.ts
 import { concat } from '../modules/utils';
 import { getTagInfo } from '../modules/tagInfo';
 import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { prepareContent } from '../modules/prepareContent';

 import type { PreprocessorGroup, Options } from '../types';

    return {
      ...transformed,
      attributes: removeSrcAttribute(transformed.attributes || attributes),
      dependencies: concat(dependencies, transformed.dependencies),
    };
  },
diff --git a/src/processors/coffeescript.ts b/src/processors/coffeescript.ts
 import { getTagInfo } from '../modules/tagInfo';
 import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';


    return {
      ...transformed,
      attributes: removeSrcAttribute(transformed.attributes || attributes),
      dependencies: concat(dependencies, transformed.dependencies),
    };
  },
diff --git a/src/processors/less.ts b/src/processors/less.ts
 import { getTagInfo } from '../modules/tagInfo';
 import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';


    return {
      ...transformed,
      attributes: removeSrcAttribute(transformed.attributes || attributes),
      dependencies: concat(dependencies, transformed.dependencies),
    };
  },
diff --git a/src/processors/postcss.ts b/src/processors/postcss.ts
 import { getTagInfo } from '../modules/tagInfo';
 import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';


    return {
      ...transformed,
      attributes: removeSrcAttribute(transformed.attributes || attributes),
      dependencies: concat(dependencies, transformed.dependencies),
    };
  },
diff --git a/src/processors/scss.ts b/src/processors/scss.ts
 import { getTagInfo } from '../modules/tagInfo';
 import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';


    return {
      ...transformed,
      attributes: removeSrcAttribute(transformed.attributes || attributes),
      dependencies: concat(dependencies, transformed.dependencies),
    };
  },
diff --git a/src/processors/stylus.ts b/src/processors/stylus.ts
 import { getTagInfo } from '../modules/tagInfo';
 import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';


    return {
      ...transformed,
      attributes: removeSrcAttribute(transformed.attributes || attributes),
      dependencies: concat(dependencies, transformed.dependencies),
    };
  },
diff --git a/src/processors/typescript.ts b/src/processors/typescript.ts
 import { getTagInfo } from '../modules/tagInfo';
 import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';


    return {
      ...transformed,
      attributes: removeSrcAttribute(transformed.attributes || attributes),
      dependencies: concat(dependencies, transformed.dependencies),
    };
  },
diff --git a/src/transformers/globalStyle.ts b/src/transformers/globalStyle.ts
    map: options?.sourceMap ? { prev: map } : false,
  });

  return { code: css, map: newMap };
  if (attributes?.global) {
    const { global, ...rest } = attributes;

    attributes = rest;
  }

  return {
    code: css,
    map: newMap,
    attributes,
  };
 };

 export { transformer };
diff --git a/test/processors/babel.test.ts b/test/processors/babel.test.ts
    ]);

    expect(preprocessed.toString?.()).toMatchInlineSnapshot(`
      "<script src="./fixtures/script.babel.js">export var hello = {};
      "<script>export var hello = {};
      export var world = hello == null ? void 0 : hello.value;</script><div></div>"
    `);
  });
Original file line number	Diff line number	Diff line change
Expand Up		@@ -123,8 +123,9 @@ export default {
		/** Add a custom language preprocessor */
		potatoLanguage({ content, filename, attributes }) {
		const { code, map } = require('potato-language').render(content);
		const { src, ...cleanedAttributes } = attributes;
Copy link Member dominikgAug 28, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. this example does not make sense as i assume potato-language uses the lang attribute value. If you want to show it here, the preprocessor would have to use a custom`potato` attribute that then gets filtered

		return { code, map };
		return { code, map, attributes: cleanedAttributes };
		},
		}),
		}),
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -67,3 +67,9 @@ export const getTagInfo = async ({
		markup,
		};
		};

		export const removeSrcAttribute = (attributes: Record<string, any>) => {
Copy link Member dominikgAug 28, 2024• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. should this be a generic util? exportconstfilterAttributes(attributes:Record<string,any>,filterFn:(a:string)=>boolean){returnObject.fromEntries(Object.entries(attributes).filter(([a])=>filterFn(a)))} usage: constcleanAttributes=filterAttributes(attributes,a=>a!=='src');// orconstattributesToRemove=['foo','bar'];constcleanMultipleAttributes=filterAttributes(attributes,a=>!attributesToRemove.includes(a)) that can be reused for global and potentially others?
		const { src, ...rest } = attributes;

		return rest;
		};
Original file line number	Diff line number	Diff line change
		@@ -1,5 +1,5 @@
		import { concat } from '../modules/utils';
		import { getTagInfo } from '../modules/tagInfo';
		import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
		import { prepareContent } from '../modules/prepareContent';

		import type { PreprocessorGroup, Options } from '../types';
Expand All		@@ -22,6 +22,7 @@ const babel = (options?: Options.Babel): PreprocessorGroup => ({

		return {
		...transformed,
		attributes: removeSrcAttribute(transformed.attributes \|\| attributes),
		dependencies: concat(dependencies, transformed.dependencies),
		};
		},
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,4 +1,4 @@
		import { getTagInfo } from '../modules/tagInfo';
		import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
		import { concat } from '../modules/utils';
		import { prepareContent } from '../modules/prepareContent';

Expand DownExpand Up		@@ -32,6 +32,7 @@ const coffeescript = (options?: Options.Coffeescript): PreprocessorGroup => ({

		return {
		...transformed,
		attributes: removeSrcAttribute(transformed.attributes \|\| attributes),
		dependencies: concat(dependencies, transformed.dependencies),
		};
		},
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -83,7 +83,17 @@ const transformer: Transformer<Options.GlobalStyle> = async ({
		map: options?.sourceMap ? { prev: map } : false,
		});

		return { code: css, map: newMap };
		if (attributes?.global) {
		const { global, ...rest } = attributes;

		attributes = rest;
		}

		return {
		code: css,
		map: newMap,
		attributes,
		};
		};

		export { transformer };
Original file line number	Diff line number	Diff line change
Expand Up		@@ -23,7 +23,7 @@ describe(`processor - babel`, () => {
		]);

		expect(preprocessed.toString?.()).toMatchInlineSnapshot(`
		"<script src="./fixtures/script.babel.js">export var hello = {};
		"<script>export var hello = {};
		export var world = hello == null ? void 0 : hello.value;</script><div></div>"
		`);
		});
Expand Down